Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support export default (Typescript related) #62

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Support export default (Typescript related) #62

merged 1 commit into from
Oct 6, 2017

Conversation

DenisCarriere
Copy link
Contributor

@DenisCarriere DenisCarriere commented Oct 6, 2017 •
edited
Loading

Support export default (Typescript related)

Mainly used for Typescript support, other bundlers like Rollup/Babel use some other "magic" to support default exports.

Same thing was done for concaveman & polylabel (PR mapbox/polylabel#10):

An update to the Typescript definition has already been made to reflect this change: DefinitelyTyped/DefinitelyTyped#20348

Rollup "magic" (import default)

import supercluster from 'supercluster'

Gets compile to:

'use strict';

function _interopDefault (ex) { return (ex && (typeof ex === 'object') && 'default' in ex) ? ex['default'] : ex; }

var supercluster = _interopDefault(require('supercluster'));

Rollup "no-magic" (import without default)

import * as supercluster from 'supercluster'

Gets compile to:

'use strict';

require('supercluster');

CC: @alex3165 @mourner

@DenisCarriere
Copy link
Contributor Author

@mourner 👍 Do you mind if I send send more PR's to all your MANY other repos?

@mourner
Copy link
Member

mourner commented Oct 6, 2017

@DenisCarriere yeah, no harm from a change like this :)

@mourner mourner merged commit 0be0042 into mapbox:master Oct 6, 2017
@DenisCarriere
Copy link
Contributor Author

DenisCarriere commented Oct 6, 2017 •
edited
Loading

@mourner Sounds good! Should I bump the package.json version while I'm at it? That way you just need to npm publish once merged

@DenisCarriere DenisCarriere deleted the patch-1 branch October 6, 2017 13:34
@mourner
Copy link
Member

mourner commented Oct 6, 2017

@DenisCarriere no, it's better for me to do npm version because it also creates a tag.

@DenisCarriere
Copy link
Contributor Author

Oh gotcha! 👍 (maybe I should do the same when I publish my repos 😄 )

@DenisCarriere
Copy link
Contributor Author

Expect ~5-10 PR's

This was referenced Oct 6, 2017
Merged
Merged
DenisCarriere added a commit to DenisCarriere/tinyqueue that referenced this pull request Oct 6, 2017
@DenisCarriere
Support export default
b972c6c 
Ref: mapbox/supercluster#62
@DenisCarriere DenisCarriere mentioned this pull request Oct 6, 2017
Merged
DenisCarriere added a commit to DenisCarriere/rbush-knn that referenced this pull request Oct 6, 2017
@DenisCarriere
Support export default
9a33a40 
Ref: mapbox/supercluster#62
@DenisCarriere DenisCarriere mentioned this pull request Oct 6, 2017
Merged
DenisCarriere added a commit to DenisCarriere/kdbush that referenced this pull request Oct 6, 2017
@DenisCarriere
Support export default
3448591 
mapbox/supercluster#62
@DenisCarriere DenisCarriere mentioned this pull request Oct 6, 2017
Merged
DenisCarriere added a commit to DenisCarriere/earcut that referenced this pull request Oct 6, 2017
@DenisCarriere
Support export default
9de5bdf 
Ref: mapbox/supercluster#62
@DenisCarriere DenisCarriere mentioned this pull request Oct 6, 2017
Merged
DenisCarriere added a commit to DenisCarriere/delaunator that referenced this pull request Oct 6, 2017
@DenisCarriere
Support export default
ab9c6b7 
Ref: mapbox/supercluster#62
@DenisCarriere DenisCarriere mentioned this pull request Oct 6, 2017
Merged
DenisCarriere added a commit to DenisCarriere/linematch that referenced this pull request Oct 6, 2017
@DenisCarriere
Support export default
1c094f0 
Ref: mapbox/supercluster#62
@DenisCarriere DenisCarriere mentioned this pull request Oct 6, 2017
Merged
DenisCarriere added a commit to DenisCarriere/lineclip that referenced this pull request Oct 6, 2017
@DenisCarriere
Support export default
33e9bf0 
Ref: mapbox/supercluster#62
@DenisCarriere DenisCarriere mentioned this pull request Oct 6, 2017
Merged
DenisCarriere added a commit to DenisCarriere/simplify-js that referenced this pull request Oct 6, 2017
@DenisCarriere
Support export default
5ad57f2 
Ref:  mapbox/supercluster#62
mourner pushed a commit to mourner/kdbush that referenced this pull request Oct 6, 2017
@DenisCarriere @mourner
Support export default (#15)
571e884 
mapbox/supercluster#62
This was referenced Oct 6, 2017
Merged
Merged
mourner pushed a commit to mourner/tinyqueue that referenced this pull request Oct 6, 2017
@DenisCarriere @mourner
Support export default (#4)
483f96f 
Ref: mapbox/supercluster#62
mourner pushed a commit to mourner/simplify-js that referenced this pull request Oct 6, 2017
@DenisCarriere @mourner
Support export default (#31)
edcf86b 
Ref:  mapbox/supercluster#62
DenisCarriere added a commit to DenisCarriere/tiny-sdf that referenced this pull request Oct 6, 2017
@DenisCarriere
Support export default
5e6c7c9 
Ref:  mapbox/supercluster#62
@DenisCarriere DenisCarriere mentioned this pull request Oct 6, 2017
Merged
mourner pushed a commit to mapbox/delaunator that referenced this pull request Oct 6, 2017
@DenisCarriere @mourner
Support export default (#14)
afbeeee 
Ref: mapbox/supercluster#62
mourner pushed a commit to mapbox/lineclip that referenced this pull request Oct 6, 2017
@DenisCarriere @mourner
Support export default (#7)
492939b 
Ref: mapbox/supercluster#62
@DenisCarriere DenisCarriere mentioned this pull request Oct 6, 2017
Merged
8 tasks
@DenisCarriere
Copy link
Contributor Author

@mourner Should be done now for the export default PR's, I've linked them all to this PR so we track them all here.

Thanks for the quick merges 👍

mourner pushed a commit to mourner/rbush-knn that referenced this pull request Oct 6, 2017
@DenisCarriere @mourner
Support export default (#9)
e113f47 
Ref: mapbox/supercluster#62
mourner pushed a commit to mapbox/tiny-sdf that referenced this pull request Oct 6, 2017
@DenisCarriere @mourner
Support export default (#7)
a951d53 
Ref:  mapbox/supercluster#62
mourner pushed a commit to mapbox/cheap-ruler that referenced this pull request Oct 6, 2017
@DenisCarriere @mourner
Support export default (#31)
028a86a 
Ref:  mapbox/supercluster#62
mourner pushed a commit to mapbox/linematch that referenced this pull request Oct 6, 2017
@DenisCarriere @mourner
Support export default (#8)
327a393 
Ref: mapbox/supercluster#62
mourner pushed a commit to mapbox/earcut that referenced this pull request Oct 6, 2017
@DenisCarriere @mourner
Support export default (#88)
b6d4c73 
Ref: mapbox/supercluster#62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenisCarriere @mourner