[@mantine/core] MultiSelect: Fix disableSelectedItemFiltering
prop not working for searchable
input
#3894
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #3877
It enables the
disableSelectedItemFiltering
feature forsearchable
inputs by always setting thefilter
function'sselected
parameter tofalse
.This works for the internal
defaultFilter
and should work for any customfilter
function that relies on theselected
parameter to remove from the list.Lastly, I added some tests to assert:
disableSelectedItemFiltering
when input isnot searchable
disableSelectedItemFiltering
when input issearchable
(usesdefaultFilter
)filter
function'sselected
paramater is alwaysfalse
whendisableSelectedItemFiltering
andsearchable
are enabled (generic test for any customfilter
function)