Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/form] Update form errors on list interactions #3828

Merged
merged 1 commit into from
Mar 28, 2023
Merged

[@mantine/form] Update form errors on list interactions #3828

merged 1 commit into from
Mar 28, 2023

Conversation

Alf-Melmac
Copy link
Contributor

@Alf-Melmac Alf-Melmac commented Mar 19, 2023 •
edited
Loading

Closes #3827

This PR changes the error state in the following ways

Function Before After
reorderListItem No changes Changes the indices from from to to
removeListItem Removed all at path Removes the error for the given index and decrements any error with a higher index than specified to account for the removed element
insertListItem No changes Increments any error with a higher index than specified to account for the inserted element

@Alf-Melmac Alf-Melmac changed the title [@mantine/form] Update form errors on reorderListItem [@mantine/form] Update form errors on list interactions Mar 20, 2023
@Alf-Melmac Alf-Melmac force-pushed the update-errors-on-form-list-changes branch from 46e1a1f to 704ae6d Compare March 21, 2023 22:05
@Alf-Melmac Alf-Melmac marked this pull request as ready for review March 21, 2023 22:16
@Alf-Melmac Alf-Melmac force-pushed the update-errors-on-form-list-changes branch from 704ae6d to aea3d38 Compare March 22, 2023 21:39
@rtivital rtivital merged commit 004b75a into mantinedev:dev Mar 28, 2023
@rtivital
Copy link
Member

Thanks!

@Alf-Melmac Alf-Melmac deleted the update-errors-on-form-list-changes branch March 28, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alf-Melmac @rtivital