[@mantine/dates]: CalendarHeader: Remove disabled level change button from tab order #3648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button for changing level is
disabledbut it's still kept in tab order whenmaxLevelshould remove it. You can try it out here: https://mantine.dev/dates/date-picker/#max-levelThe DatePicker at the right has
maxLevel="month", so the level change button is disabled, but it still hastabIndex={0}and is therefore kept in tab order.This worked correctly in v5.x: https://v5.mantine.dev/dates/calendar/#level-change
Let me know if I should create an issue for this instead of opening a PR!
Repro here: https://codesandbox.io/s/silly-forest-fcvs01?file=/src/App.tsx