Added option to disable removing of optional attribute quotes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mankyd
added a commit
that referenced
this pull request
Jan 8, 2014
Added option to disable removing of optional attribute quotes
|
Great, thanks! Would it be possible to also have it pushed to pypi? |
|
@zeebonk Zit je nou een beetje ons oude kantoor over te nemen? Pas op: de mensen boven kunnen je horen als een nummer 2 doet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently in a situation where I'm minifying html snippets where we use placeholders in attributes which get replaced later on. Because the quotes are optional based on the content of the attribute, which isn't yet known when minifying, the quotes are removed when they shouldn't be. I've added an extra option to disable the removing of quotes completely.
PS: I just noticed my editor removed some trailing whitespace, which ads some noise to the commit. I hope this isn't a problem.