Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to latest @nuxt/module-builder #147

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

danielroe
Copy link
Contributor

@danielroe danielroe commented Aug 25, 2024

Is your PR related to a specific issue/feature? Please describe and mention issues.

Previous versions of @nuxt/module-builder produced incorrect types for files in the runtime/ directory. Specifically, a .d.ts declaration paired with a .mjs file. This isn't correct - it should be either .d.mts and .mjs or .d.ts and .js.

For maximum compatibility, @nuxt/module-builder v0.8 switched to .js extension for files in runtime/ directory.

With the latest Nuxt, this is now an error that removes correct plugin injection types.

Related PRs: nuxt/nuxt#28480, nuxt/nuxt#28593
See also nuxt/nuxt#28672.

Additional context

Add any other context or screenshots about the feature request here.

Checklist:

  • Code style and linters are passing
  • Backwards compatibility is maintained
  • Documentation is updated

@manchenkoff
Copy link
Owner

Thanks a lot @danielroe for opening this!

@manchenkoff manchenkoff merged commit 21d318e into manchenkoff:main Aug 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants