Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-3090]fix: added missing translation #6367

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[WEB-3090]fix: added missing translation #6367

merged 1 commit into from
Jan 10, 2025

Conversation

mathalav55
Copy link
Collaborator

@mathalav55 mathalav55 commented Jan 9, 2025 •
edited by coderabbitai bot
Loading

Description

Added missing translation for 'update'.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

References

WEB-3090

Summary by CodeRabbit

  • Localization

    • Added "Update" translation for English, Spanish, French, and Japanese languages

  • Chores

    • Removed and re-added duplicate import in recent activity widget component (no functional change)

@mathalav55 mathalav55 added 🐛bug Something isn't working 🌐frontend labels Jan 9, 2025
@mathalav55 mathalav55 added this to the v0.24.2 milestone Jan 9, 2025
@mathalav55 mathalav55 self-assigned this Jan 9, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 9, 2025 •
edited
Loading

Walkthrough

This pull request focuses on internationalization (i18n) updates across multiple language translation files. The changes involve adding a new translation key "update" with localized values in English, Spanish, French, and Japanese translation JSON files. Additionally, there's a minor import statement adjustment in a TypeScript React component file, which does not impact the component's functionality.

Changes

File Change Summary
packages/i18n/src/locales/*/translations.json Added new translation key "update" with localized values:
- English: "Update"
- Spanish: "Actualizar"
- French: "Mettre à jour"
- Japanese: "更新"
web/core/components/home/widgets/recents/index.tsx Removed and re-added identical import statement for ContentOverflowWrapper

Poem

🐰 Translations hop from shore to shore,
"Update" now speaks in tongues galore!
English, Spanish, French, and more,
Japanese joins the linguistic core.
A rabbit's guide to global lore! 🌍

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ddd709 and 2e47b71.

📒 Files selected for processing (5)
  • packages/i18n/src/locales/en/translations.json (1 hunks)
  • packages/i18n/src/locales/es/translations.json (1 hunks)
  • packages/i18n/src/locales/fr/translations.json (1 hunks)
  • packages/i18n/src/locales/ja/translations.json (1 hunks)
  • web/core/components/home/widgets/recents/index.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • web/core/components/home/widgets/recents/index.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/i18n/src/locales/ja/translations.json (1)

285-285: LGTM! Correct Japanese translation.

The translation "更新" is the appropriate term for "update" in Japanese, maintaining consistency with common UI terminology.

packages/i18n/src/locales/en/translations.json (1)

286-286: LGTM! Follows English capitalization convention.

The entry maintains consistency with the existing capitalization pattern in the file.

packages/i18n/src/locales/es/translations.json (1)

285-285: LGTM! Correct Spanish translation.

The translation "Actualizar" is the appropriate Spanish term, using the correct infinitive form consistent with other action verbs in the file.

packages/i18n/src/locales/fr/translations.json (1)

285-285: LGTM! Correct French translation.

The translation "Mettre à jour" is the appropriate French term, using the standard infinitive form consistent with other action verbs in the file.

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 merged commit 2018114 into preview Jan 10, 2025
10 of 14 checks passed
@pushya22 pushya22 deleted the fix-language_support branch January 10, 2025 04:49
This was referenced Jan 11, 2025
Merged
Merged
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekshourya29 prateekshourya29 prateekshourya29 approved these changes

@rahulramesha rahulramesha Awaiting requested review from rahulramesha

Assignees

@mathalav55 mathalav55

Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Milestone
v0.24.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mathalav55 @prateekshourya29 @pushya22