-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-2817] fix: creating a new sub-issue from workspace level #6169
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)web/core/components/issues/issue-detail-widgets/issue-detail-widget-modals.tsx (2)
The addition of Line range hint The modal configuration looks correct, but let's verify that:
✅ Verification successfulLet me gather more specific information about the modal and its configuration. Let me search for one final piece of information about how the project selection is handled in the form. Based on the gathered information, I can now provide a conclusive response about the sub-issue creation behavior. Sub-issue creation behavior is properly enforced The code inspection confirms that:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for any other instances where CreateUpdateIssueModal is used
# to ensure consistent behavior across the application
# Look for CreateUpdateIssueModal usage
ast-grep --pattern 'CreateUpdateIssueModal $$$'
# Check for any other locations handling sub-issue creation
rg -A 5 'parent_id.*project_id'
Length of output: 519 Script: #!/bin/bash
# Search for CreateUpdateIssueModal component definition and its props
ast-grep --pattern 'interface $_ {
$$$
isProjectSelectionDisabled?: $_
$$$
}'
# Look for createUpdateModalData construction
rg -A 5 "createUpdateModalData"
# Search for project selection handling in the modal
rg -A 3 "isProjectSelectionDisabled"
Length of output: 10573 Script: #!/bin/bash
# Look for project selection component and its implementation
ast-grep --pattern 'ProjectSelect'
# Check how createUpdateModalData is constructed and used
rg -B 5 "createUpdateModalData.*project_id"
Length of output: 80 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Bug fix:
When creating a new sub-issue from inbox or all issues page, the selected project id is incorrect.
GitHub issue: #6166
Summary by CodeRabbit