Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-2817] fix: creating a new sub-issue from workspace level #6169

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

aaryan610
Copy link
Collaborator

@aaryan610 aaryan610 commented Dec 7, 2024

Bug fix:

When creating a new sub-issue from inbox or all issues page, the selected project id is incorrect.

GitHub issue: #6166

Summary by CodeRabbit

  • New Features
    • Enhanced modal for creating and updating issues with improved data structure.
  • Bug Fixes
    • Added error handling for submissions without selected issues, providing user notifications.

@aaryan610 aaryan610 added 🐛bug Something isn't working 🌐frontend labels Dec 7, 2024
@aaryan610 aaryan610 added this to the v0.24.0 milestone Dec 7, 2024
Copy link
Contributor

coderabbitai bot commented Dec 7, 2024

Walkthrough

The pull request modifies the IssueDetailWidgetModals component in the issue-detail-widget-modals.tsx file. A significant change is the addition of the project_id property to the createUpdateModalData object, which is now a Partial<TIssue> type. The submission function handleExistingIssueModalOnSubmit has been updated to include error handling for unselected issues, triggering a toast notification in such cases. The rendering logic for modals remains unchanged, focusing on enhancing data structure and improving error handling during submissions.

Changes

File Path Change Summary
web/core/components/issues/issue-detail-widgets/issue-detail-widget-modals.tsx Updated createUpdateModalData to include project_id and changed its type to Partial<TIssue>. Enhanced error handling in handleExistingIssueModalOnSubmit to notify users when no issues are selected.

Possibly related PRs

Suggested labels

⚙️backend

Suggested reviewers

  • sriramveeraghanta
  • SatishGandham
  • rahulramesha

Poem

🐇 In the meadow, changes bloom,
Modals dance, dispelling gloom.
With project ID, data's bright,
Errors caught, all feels right!
Toasts of joy, for issues clear,
A hop of joy, we hold so dear! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9ee41ec and d2c611e.

📒 Files selected for processing (1)
  • web/core/components/issues/issue-detail-widgets/issue-detail-widget-modals.tsx (1 hunks)
🔇 Additional comments (2)
web/core/components/issues/issue-detail-widgets/issue-detail-widget-modals.tsx (2)

124-127: LGTM: Project ID is now correctly passed to create sub-issues

The addition of project_id to createUpdateModalData ensures that sub-issues are created with the correct project association, directly addressing the bug described in WEB-2817.


Line range hint 147-155: Verify the sub-issue creation behavior

The modal configuration looks correct, but let's verify that:

  1. Sub-issues are always created in the correct project
  2. Project selection remains disabled during creation
✅ Verification successful

Let me gather more specific information about the modal and its configuration.


Let me search for one final piece of information about how the project selection is handled in the form.


Based on the gathered information, I can now provide a conclusive response about the sub-issue creation behavior.

Sub-issue creation behavior is properly enforced

The code inspection confirms that:

  1. The createUpdateModalData explicitly sets the project_id to the parent issue's project
  2. The isProjectSelectionDisabled prop is properly passed through the component hierarchy
  3. The form component respects this prop by disabling project selection when isProjectSelectionDisabled is true
  4. The project selection field is disabled when there's a parent issue (data?.sourceIssueId) as verified in the form implementation
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any other instances where CreateUpdateIssueModal is used
# to ensure consistent behavior across the application

# Look for CreateUpdateIssueModal usage
ast-grep --pattern 'CreateUpdateIssueModal $$$'

# Check for any other locations handling sub-issue creation
rg -A 5 'parent_id.*project_id'

Length of output: 519


Script:

#!/bin/bash
# Search for CreateUpdateIssueModal component definition and its props
ast-grep --pattern 'interface $_ {
  $$$
  isProjectSelectionDisabled?: $_
  $$$
}'

# Look for createUpdateModalData construction
rg -A 5 "createUpdateModalData" 

# Search for project selection handling in the modal
rg -A 3 "isProjectSelectionDisabled"

Length of output: 10573


Script:

#!/bin/bash
# Look for project selection component and its implementation
ast-grep --pattern 'ProjectSelect'

# Check how createUpdateModalData is constructed and used
rg -B 5 "createUpdateModalData.*project_id"

Length of output: 80


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SatishGandham SatishGandham merged commit a85e592 into preview Dec 9, 2024
13 of 14 checks passed
@SatishGandham SatishGandham deleted the fix/workspace-level-issue branch December 9, 2024 06:45
nishantPFM pushed a commit to Pocket-Fm/plane that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants