apiserver/plane/app/views/project/base.py (2)

Line range hint 441-458: New inbox and triage state creation

The method now creates a default inbox and triage state if they don't exist. This is a good addition for consistency in project management.

However, consider adding error handling for the inbox and state creation processes.

Consider wrapping the inbox and state creation in a try-except block:

 if serializer.data["inbox_view"]:
+    try:
         inbox = Inbox.objects.filter(
             project=project,
             is_default=True,
         ).first()
         if not inbox:
             Inbox.objects.create(
                 name=f"{project.name} Inbox",
                 project=project,
                 is_default=True,
             )

         # Create the triage state in Backlog group
         State.objects.get_or_create(
             name="Triage",
             group="triage",
             description="Default state for managing all Inbox Issues",
             project_id=pk,
             color="#ff7700",
             is_triage=True,
         )
+    except Exception as e:
+        return Response(
+            {"error": f"Failed to create inbox or triage state: {str(e)}"},
+            status=status.HTTP_500_INTERNAL_SERVER_ERROR
+        )

---

Line range hint 460-472: Add logging for new functionality

Consider adding logging statements for the creation of the inbox and triage state. This will help with debugging and monitoring the system's behavior.

Add logging statements after the inbox and state creation:

 if serializer.data["inbox_view"]:
     inbox = Inbox.objects.filter(
         project=project,
         is_default=True,
     ).first()
     if not inbox:
         Inbox.objects.create(
             name=f"{project.name} Inbox",
             project=project,
             is_default=True,
         )
+        logger.info(f"Created default inbox for project {project.id}")

     # Create the triage state in Backlog group
     State.objects.get_or_create(
         name="Triage",
         group="triage",
         description="Default state for managing all Inbox Issues",
         project_id=pk,
         color="#ff7700",
         is_triage=True,
     )
+    logger.info(f"Created or got triage state for project {project.id}")

apiserver/plane/app/views/estimate/base.py (4)

263-287: Optimize Task Queue Processing

Currently, issue_activity.delay() is called within a loop for each issue. If there are many issues, this will enqueue a large number of tasks, which could overwhelm the task processing system.

[performance]

Consider batching the activity logging:

• Option 1: Modify issue_activity to accept a list of issues and process them in a single task.
• Option 2: Use group tasks or chunking provided by your task queue (e.g., Celery) to manage the workload efficiently.

This change will improve the scalability and performance of your application.

---

267-285: Simplify requested_data and current_instance Assignments

The use of complex ternary expressions within the JSON dumps can be simplified for readability.

For example, in requested_data:

"estimate_point": new_estimate_point

Since new_estimate_point is already set appropriately before the loop, you can use it directly.

Similarly, in current_instance:

"estimate_point": str(issue.estimate_point_id) if issue.estimate_point_id else None

This expression is acceptable, but consider assigning it to a variable for clarity:

current_estimate_point = (
    str(issue.estimate_point_id) if issue.estimate_point_id else None
)

And then:

"estimate_point": current_estimate_point

This makes the code cleaner and easier to read.

Also applies to: 298-316

---

306-316: Time Zone Awareness

When using timezone.now().timestamp(), ensure that the timestamp is time zone aware and consistent across your application.

If your application relies on UTC, you might want to explicitly use timezone.utc or datetime.utcnow().

epoch = int(datetime.datetime.utcnow().timestamp())

Ensure consistency with your application's time zone settings.

---

Line range hint 232-238: Validate Unique Keys for Estimate Points

In the create and partial_update methods for EstimatePointEndpoint, there is a TODO comment about adding key validation for duplicates.

Implement key uniqueness validation to prevent multiple estimate points with the same key in an estimate.

You can add a validation check:

if EstimatePoint.objects.filter(
    estimate_id=estimate_id,
    key=request.data.get("key")
).exists():
    return Response(
        {"error": "An estimate point with this key already exists."},
        status=status.HTTP_400_BAD_REQUEST,
    )

Would you like assistance in implementing this validation?

Configuration used: CodeRabbit UI
Review profile: CHILL