Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-2237] fix: intake issue accept modal #5465

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[WEB-2237] fix: intake issue accept modal #5465

merged 1 commit into from
Aug 29, 2024

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Aug 29, 2024 •
edited by coderabbitai bot
Loading

Changes:

This PR fixes a bug in the intake create/update modal where users couldn't unselect parent once selected. I've made the necessary changes to resolve this issue.

Reference:

[WEB-2237]

Summary by CodeRabbit

  • Bug Fixes
    • Improved the functionality of the parent issue removal in the inbox modal, ensuring that both the parent ID and the selected parent issue state are reset correctly to enhance user experience.

@anmolsinghbhatia anmolsinghbhatia added this to the v0.23-dev milestone Aug 29, 2024
@anmolsinghbhatia anmolsinghbhatia self-assigned this Aug 29, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 29, 2024 •
edited
Loading

Walkthrough

The update modifies the onClick event handler of the CustomMenu.MenuItem component in the InboxIssueProperties functional component. It enhances the existing functionality by adding a call to setSelectedParentIssue with undefined, in addition to clearing the "parent_id". This change aims to improve state management related to the selected parent issue.

Changes

Files Change Summary
web/core/components/inbox/modals/create-edit-modal/issue-properties.tsx Modified onClick handler to include resetting the selected parent issue state along with clearing the "parent_id".

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CustomMenu
    participant InboxIssueProperties

    User->>CustomMenu: Click on MenuItem
    CustomMenu->>InboxIssueProperties: Trigger onClick event
    InboxIssueProperties->>InboxIssueProperties: Clear parent_id
    InboxIssueProperties->>InboxIssueProperties: Reset selectedParentIssue to undefined
Loading

Poem

🐰 In the garden where issues bloom,
A click brings light, dispels the gloom.
Parent cleared, a fresh new start,
With choices bright, we play our part.
Hopping high with joy and cheer,
The path ahead is crystal clear! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6d8ba9d and dbd172a.

Files selected for processing (1)
  • web/core/components/inbox/modals/create-edit-modal/issue-properties.tsx (1 hunks)
Additional comments not posted (1)
web/core/components/inbox/modals/create-edit-modal/issue-properties.tsx (1)

182-188: LGTM!

The change ensures that the selected parent issue state is reset when the parent issue is removed.

The code changes are approved.

@SatishGandham SatishGandham merged commit 33ab602 into preview Aug 29, 2024
14 checks passed
@SatishGandham SatishGandham deleted the fix-intake-issue-accept-modal branch August 29, 2024 13:56
@coderabbitai coderabbitai bot mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@SatishGandham SatishGandham SatishGandham approved these changes

@sriramveeraghanta sriramveeraghanta Awaiting requested review from sriramveeraghanta

Assignees

@anmolsinghbhatia anmolsinghbhatia

Labels
🐛bug Something isn't working 🧹chore 🌐frontend
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anmolsinghbhatia @SatishGandham