Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-2304] fix: increase z-index from z-20 to z-[21] in dropdown.tsx #5446

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[WEB-2304] fix: increase z-index from z-20 to z-[21] in dropdown.tsx #5446

merged 1 commit into from
Aug 29, 2024

Conversation

sharma01ketan
Copy link
Collaborator

@sharma01ketan sharma01ketan commented Aug 28, 2024 •
edited by coderabbitai bot
Loading

Changes:

Left Side Nav Menus' scrollbar was visible in Safari Browser above the workspace switcher dropdown, when are opened together.
Increased z index of dropdown.tsx from z-20 to z-[21].

Previous State:
Screenshot 2024-08-28 at 3 13 17 PM

New State:
Screenshot 2024-08-28 at 3 13 45 PM

Reference:

[WEB-2304]

Summary by CodeRabbit

  • Enhancements
    • Improved visibility and interaction within the sidebar dropdown menu by adjusting the z-index of the main dropdown container and sticky header.

These changes ensure that key elements are properly layered, enhancing the overall user experience.

@sharma01ketan sharma01ketan added 🐛bug Something isn't working 🌐frontend labels Aug 28, 2024
@sharma01ketan sharma01ketan added this to the v0.23-dev milestone Aug 28, 2024
@sharma01ketan sharma01ketan self-assigned this Aug 28, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2024 •
edited
Loading

Walkthrough

The changes made to the SidebarDropdown component involve increasing the z-index values of the main dropdown container and the sticky header from z-20 to z-[21]. This adjustment ensures that these elements are displayed above other overlapping components, enhancing their visibility within the sidebar dropdown menu.

Changes

Files Change Summary
web/core/components/workspace/sidebar/... Updated z-index of main dropdown container and sticky header from z-20 to z-[21].

Sequence Diagram(s)

(Not applicable as changes are too simple.)

Poem

In the sidebar where we play,
New heights for dropdowns bright as day!
With z-index raised, they stand so tall,
A clearer view for one and all.
Hop along, let’s cheer and say,
"Visibility wins, hip-hip-hooray!" 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0cce39e and 8fc989b.

Files selected for processing (1)
  • web/core/components/workspace/sidebar/dropdown.tsx (2 hunks)
Files skipped from review due to trivial changes (1)
  • web/core/components/workspace/sidebar/dropdown.tsx

@SatishGandham SatishGandham merged commit dc2e7ca into preview Aug 29, 2024
13 of 14 checks passed
@SatishGandham SatishGandham deleted the fix/sidenav-scrollbar-overlap-in-safari branch August 29, 2024 13:55
@coderabbitai coderabbitai bot mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@anmolsinghbhatia anmolsinghbhatia anmolsinghbhatia approved these changes

@SatishGandham SatishGandham Awaiting requested review from SatishGandham

Assignees

@sharma01ketan sharma01ketan

Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sharma01ketan @anmolsinghbhatia @SatishGandham