Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-2146] fix: fetch issue activity on peek issue update #5289

Merged
merged 1 commit into from
Aug 2, 2024
Merged

[WEB-2146] fix: fetch issue activity on peek issue update #5289

merged 1 commit into from
Aug 2, 2024

Conversation

rahulramesha
Copy link
Collaborator

@rahulramesha rahulramesha commented Aug 2, 2024 •
edited by coderabbitai bot
Loading

This Issue fixes the issue activity mutation while updating the issue from peek overview.

Screen.Recording.2024-08-02.at.5.59.04.PM.mov

Summary by CodeRabbit

  • New Features
    • Enhanced the IssuePeekOverview component to fetch and display real-time activity data whenever issues are updated or modified.
    • Improved responsiveness of the UI by ensuring that the latest activities are displayed immediately after issue state changes.

@rahulramesha rahulramesha added 🐛bug Something isn't working 🌐frontend labels Aug 2, 2024
@rahulramesha rahulramesha added this to the v0.23-dev milestone Aug 2, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 2, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are limited to specific labels.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent updates to the IssuePeekOverview component significantly improve the handling of activity data related to issues. By integrating a new fetchActivities function into the component’s props, the application can now retrieve and display real-time activity updates whenever an issue undergoes modifications. This change enhances user interaction, ensuring that the displayed information stays current and relevant following state changes.

Changes

File Path Change Summary
web/core/components/issues/peek-overview/root.tsx Introduced fetchActivities in props, called after issue updates (e.g., updateIssue, addCycleToIssue), ensuring real-time activity data retrieval.

Poem

🐰 In the meadow where issues play,
A fetch of activities brightens the day.
With updates that spring like a hop in the air,
Our data stays fresh, with joy we share!
So here's to the changes, both swift and clever,
In the world of issues, we'll thrive forever! 🌼✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rahulramesha rahulramesha mentioned this pull request Aug 2, 2024
Closed
coderabbitai[bot]
coderabbitai bot reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 76983a5 and f8ad861.

Files selected for processing (1)
  • web/core/components/issues/peek-overview/root.tsx (6 hunks)
Additional comments not posted (6)
web/core/components/issues/peek-overview/root.tsx (6)

38-38: Integration of fetchActivities looks good.

The fetchActivities function is correctly introduced into the component's props.

71-72: Correct usage of fetchActivities after issue update.

The fetchActivities function is correctly called after updating an issue. Error handling is also properly managed.

167-167: Correct usage of fetchActivities after adding cycle to issue.

The fetchActivities function is correctly called after adding a cycle to an issue. Error handling is also properly managed.

238-238: Correct usage of fetchActivities after removing issue from cycle.

The fetchActivities function is correctly called after removing an issue from a cycle. Error handling is also properly managed.

274-274: Correct usage of fetchActivities after changing modules in issue.

The fetchActivities function is correctly called after changing modules in an issue. Error handling is also properly managed.

301-301: Correct usage of fetchActivities after removing issue from module.

The fetchActivities function is correctly called after removing an issue from a module. Error handling is also properly managed.

@SatishGandham SatishGandham merged commit 3a5c77e into preview Aug 2, 2024
13 of 14 checks passed
@SatishGandham SatishGandham deleted the fix-issue-activity-mutation branch August 2, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@SatishGandham SatishGandham SatishGandham approved these changes

Assignees
No one assigned
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulramesha @SatishGandham