[WEB-522] chore: enabled estimate point analytics for module and cycle #4763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne/plane into estimate-module-cycle-analytics
…dule-cycle-analytics
…e/plane into estimate-module-cycle-analytics
…odule-cycle-analytics
…ne/plane into estimate-module-cycle-analytics
…ne/plane into estimate-module-cycle-analytics
…odule-cycle-analytics
…e/plane into estimate-module-cycle-analytics
web/core/store/module.store.ts
Outdated
| runInAction(() => { | ||
| set(this.moduleMap, [moduleId], response); | ||
| }); | ||
| return response; |
There was a problem hiding this comment.
Are we using this returned value anywhere?
| moduleDetails.distribution?.completion_chart && ( | ||
| <Fragment> | ||
| {plotType === "points" && totalEstimatePoints ? ( | ||
| <ProgressChart |
There was a problem hiding this comment.
Would it be better if we change the last two props conditionally?
| distribution={moduleDetails.distribution} | ||
| groupedIssues={{ | ||
| backlog: | ||
| plotType === "points" |
There was a problem hiding this comment.
Can you extract this into a function.
pablohashescobar
approved these changes
Jun 12, 2024
…ne/plane into estimate-module-cycle-analytics
SatishGandham
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.