Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-1390] chore: Add pre commit hook to check for lint and formatting errors #4537

Merged
merged 2 commits into from
May 22, 2024
Merged

[WEB-1390] chore: Add pre commit hook to check for lint and formatting errors #4537

merged 2 commits into from
May 22, 2024

Conversation

SatishGandham
Copy link
Contributor

WEB-1390

  • Add pre commit hook which checks for the lint and formatting errors
  • This adds additional plugins for ESLINT with more useful rules that only apply to the staged files. We should eventually apply the rules across the project.

You can skip this check by passing --no-verify to git commit command.

@SatishGandham SatishGandham changed the title [WEB-1390] chore: Add pre commit hook [WEB-1390] chore: Add pre commit hook to check for lint and formatting error May 22, 2024
@SatishGandham SatishGandham changed the title [WEB-1390] chore: Add pre commit hook to check for lint and formatting error [WEB-1390] chore: Add pre commit hook to check for lint and formatting errors May 22, 2024
@sriramveeraghanta sriramveeraghanta merged commit 6236adf into preview May 22, 2024
13 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the add_pre_commit_hook branch May 22, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SatishGandham @sriramveeraghanta