Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a button to truncate the error table BUT not to retry the objects with erros #1498

Closed
gonzaloebiz opened this issue Aug 10, 2022 · 1 comment · Fixed by #1499, #1500, #1501, #1502 or #1503
Closed

Add a button to truncate the error table BUT not to retry the objects with erros #1498

gonzaloebiz opened this issue Aug 10, 2022 · 1 comment · Fixed by #1499, #1500, #1501, #1502 or #1503
Assignees
@gonzaloebiz
Labels
enhancement Magento 2.1 Magento 2.2 Magento 2.3 Magento 2.4
Milestone
10x.x.47

Comments

@gonzaloebiz
Copy link
Collaborator

Preconditions

1. Magento CE without sample data is installed.
2. mc-magento2 installed in a version <= 10x.x.46
3. magento cron configured and running and wait until the store is completely synched

Steps to reproduce

1. Go to the Mailchimp error grid, you can see something like

image

2. Go to the configuration page of the extension and click on the reset errors button

image

3. Wait until the sync runs

Actual and Expected result

The sync runs and sends the objects to Mailchimp, and the objects already contain errors and are saved in the error grid.
Need to have an option to truncate the errors table and prevent that the objects will be synced
@gonzaloebiz gonzaloebiz self-assigned this Aug 10, 2022
@gonzaloebiz gonzaloebiz added this to the 10x.x.47 milestone Aug 10, 2022
gonzaloebiz added a commit that referenced this issue Aug 10, 2022
@gonzaloebiz
add a button in the admin to no retry when truncate the errors table #…
8f48532 
…1498 for magento 2.4
@gonzaloebiz gonzaloebiz mentioned this issue Aug 10, 2022
Merged
@gonzaloebiz gonzaloebiz linked a pull request Aug 10, 2022 that will close this issue
add a button in the admin to no retry when truncate the errors table … #1499
Merged
gonzaloebiz added a commit that referenced this issue Aug 10, 2022
@gonzaloebiz
add a button in the admin to no retry when truncate the errors table #…
4ec6fd4 
…1498 for magento 2.1
@gonzaloebiz gonzaloebiz mentioned this issue Aug 10, 2022
Merged
@gonzaloebiz gonzaloebiz linked a pull request Aug 10, 2022 that will close this issue
add a button in the admin to no retry when truncate the errors table … #1500
Merged
gonzaloebiz added a commit that referenced this issue Aug 10, 2022
@gonzaloebiz
add a button in the admin to no retry when truncate the errors table #…
c3792f9 
…1498 for magento 2.2
@gonzaloebiz gonzaloebiz mentioned this issue Aug 10, 2022
Merged
@gonzaloebiz gonzaloebiz linked a pull request Aug 10, 2022 that will close this issue
add a button in the admin to no retry when truncate the errors table … #1501
Merged
gonzaloebiz added a commit that referenced this issue Aug 10, 2022
@gonzaloebiz
add a button in the admin to no retry when truncate the errors table #…
b718545 
…1498 for magento 2.3.6-p1
gonzaloebiz added a commit that referenced this issue Aug 10, 2022
@gonzaloebiz
add a button in the admin to no retry when truncate the errors table #…
c5dac4d 
…1498 for magento 2.3
@gonzaloebiz gonzaloebiz mentioned this issue Aug 10, 2022
Merged
@gonzaloebiz gonzaloebiz linked a pull request Aug 10, 2022 that will close this issue
add a button in the admin to no retry when truncate the errors table … #1502
Merged
@gonzaloebiz gonzaloebiz mentioned this issue Aug 10, 2022
Merged
@gonzaloebiz gonzaloebiz linked a pull request Aug 10, 2022 that will close this issue
add a button in the admin to no retry when truncate the errors table … #1503
Merged
@steverobbins
Copy link

This is a good start, but it would be nice if there was a created_at column on this table, then a setting/cron to delete anything older than X days. This table grows to 10GB+ for my site, our admins don't know they need to clear it out, it should be automatic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gonzaloebiz gonzaloebiz

Labels
enhancement Magento 2.1 Magento 2.2 Magento 2.3 Magento 2.4
Projects
None yet
Milestone
10x.x.47
2 participants
@steverobbins @gonzaloebiz