Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes bower package file name and adds bower details in readme #7

Merged
merged 4 commits into from
Jun 18, 2014

Conversation

M1ke
Copy link
Contributor

@M1ke M1ke commented Jun 18, 2014

Bower have changed the name of their package file - it is now bower.json to avoid conflicts with npm.

I've made this change and also added a slight extra to the readme file with instructions on installing with bower for those who haven't yet got into using it.

@M1ke
Copy link
Contributor Author

M1ke commented Jun 18, 2014

As an additional point - the current package file will work, but dependencies might not be correctly resolved - this was how I first realised that they'd deprecated that format.

@mahnunchik
Copy link
Owner

We should keep package.json file too.
It is necessary for npm installation for example for browserify.

@M1ke
Copy link
Contributor Author

M1ke commented Jun 18, 2014

Agreed; I think from a point of view of commits we should commit package.json -> bower.json and then add a new package.json to handle npm.

(Though supporting Browserify would require some extra work with the exports model too)

@M1ke
Copy link
Contributor Author

M1ke commented Jun 18, 2014

Done!

mahnunchik added a commit that referenced this pull request Jun 18, 2014
Adds bower.json and bower details in readme
@mahnunchik mahnunchik merged commit 73cc61a into mahnunchik:master Jun 18, 2014
@mahnunchik
Copy link
Owner

Thanks!

(Though supporting Browserify would require some extra work with the exports model too)

Yes, but I have no enough time now=(

@M1ke
Copy link
Contributor Author

M1ke commented Jun 18, 2014

Yeah, I was hacking away last night to try and make a generic compiler that would expose items for browserify, but not sure it's always feasible with big packages like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants