[orc8r][service_registry] Add cache to service registry service #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magmabot
added
component: agw
Signed-off-by: Hunter Gatewood <hgatewood@gmail.com>
themarwhal
pushed a commit
that referenced
this pull request
Feb 2, 2021
Signed-off-by: Hunter Gatewood <hgatewood@gmail.com>
HannaFar
pushed a commit
to HannaFar/magma
that referenced
this pull request
Feb 3, 2021
…a#4648) Signed-off-by: Hunter Gatewood <hgatewood@gmail.com> Signed-off-by: HannaFar <hannafarag159@gmail.com>
|
closes #4622 |
chandra-77
pushed a commit
to chandra-77/magma
that referenced
this pull request
Mar 30, 2021
…a#4648) Signed-off-by: Hunter Gatewood <hgatewood@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're getting rate limited trying to reach the kube-apiserver for service queries. This PR adds a cache to the service_registry service, updated with configurable frequency, which service_registry's gRPC methods can use instead of going over the network.
One notable quirk: we're using
service_registry.ymlas both the generic orc8r service registry file, as well as the service-specific config file for service_registry service. Should be fine though, since the service registry configs are scoped under theserviceskeyTest Plan
Additional Information