[lte][agw] Add condition for context not found in delete session response #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ulas Kozat <kozat@fb.com>
ulaskozat
added
component: agw
ssanadhya
approved these changes
Dec 3, 2020
Signed-off-by: Ulas Kozat <kozat@fb.com>
ssanadhya
approved these changes
Dec 3, 2020
ulaskozat
removed
apply-v1.1
themarwhal
pushed a commit
that referenced
this pull request
Dec 3, 2020
…onse (#3878) * Add condition for context not found in delete session response Signed-off-by: Ulas Kozat <kozat@fb.com>
jaredmullane
pushed a commit
to jaredmullane/magma
that referenced
this pull request
Dec 3, 2020
…onse (magma#3878) * Add condition for context not found in delete session response Signed-off-by: Ulas Kozat <kozat@fb.com> Signed-off-by: Jared Mullane <jmullane@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ulas Kozat kozat@fb.com
Summary
When context is not found in SPGW task, session request response does not include any LBI information; instead a specific CONTEXT_NOT_FOUND cause is returned back to MME. As MME code was not considering this situation, it was leading to a crash while trying to access the session context.
Test Plan
Sanity tests.
Also tested with a modified MME binary to trigger the case.