[agw] [stateless MME] Fix for failing stateless AGW integration tests #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssanadhya
changed the title
ulaskozat
reviewed
Oct 28, 2020
Comment on lines
165
to
168
| hashtable_uint64_ts_destroy(s1ap_imsi_map_->mme_ue_id_imsi_htbl); | ||
|
|
||
| free_wrapper((void**) &s1ap_imsi_map_); | ||
|
|
||
| if (persist_state_enabled) { | ||
| std::vector<std::string> keys_to_del; | ||
| keys_to_del.emplace_back(S1AP_IMSI_MAP_TABLE_NAME); | ||
| redis_client->clear_keys(keys_to_del); | ||
| } | ||
| } |
There was a problem hiding this comment.
is S1apStateManager::clear_s1ap_imsi_map() called only during the service exit?
There was a problem hiding this comment.
Yes, it is only called at service exit, to clear all the memory allocated to the hashtable.
ssanadhya
changed the title
ssanadhya
changed the title
ssanadhya
force-pushed
the
sl_test_fix
branch
from
b6b90e4 to
93751f0
Compare
ardzoht
approved these changes
Oct 28, 2020
Signed-off-by: Shruti Sanadhya <ssanadhya@fb.com>
Signed-off-by: Shruti Sanadhya <ssanadhya@fb.com>
Signed-off-by: Shruti Sanadhya <ssanadhya@fb.com>
Signed-off-by: Shruti Sanadhya <ssanadhya@fb.com>
ssanadhya
force-pushed
the
sl_test_fix
branch
from
93751f0 to
70f0933
Compare
ssanadhya
changed the title
|
Merging despite Jenkins CI failures as those failures are unrelated to this change. |
ssanadhya
added
the
apply-v1.3
ssanadhya
added a commit
that referenced
this pull request
Nov 20, 2020
…#3462) * Stop clearing s1ap_imsi_map from Redis * Re-adding stateless tests in sanity suite * Remove sleep from sctpd_post block in config_stateless_agw script * Commenting out data tests for stateless Signed-off-by: Shruti Sanadhya <ssanadhya@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Running the test
test_attach_detach_with_<service>_restart.pyfor mme or mobilityd multiple times in a row was showing a failure while trying to detach an attached UE. This was happening as thes1ap_imsi_maptable was getting cleared from Redis every time the MME process exited, leading to the error:Received S1AP UPLINK_NAS_TRANSPORT No UE is attached to this mme_ue_s1ap_idThis error only showed up for the second run of the test case even though each test case attaches/detaches two UEs. This is because the first UE detaches with detach-type "Normal detach", which triggered procedures to re-insert the entry in
s1ap_imsi_map. Only for the second UE, which detached with detach-type "Switch-off" the map stays empty forever.This change fixes this issue by
Test Plan
test_attach_detach_with_mme_restart.pymultiple times and make sure the above error does not occur