This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Improve build and deploy env definitions #8843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Vaimo
partners-contribution
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
hguthrie
suggested changes
Mar 29, 2021
There was a problem hiding this comment.
Looks good in the SCD Performance section.
Not so keen on the addition to the File structure section.
If you duplicate the content and one set changes, then it stands to reason they both might require the same change. If there must be two instances of this information, then I recommend creating an _include file, that way if you change one, you change them all.
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
hguthrie
approved these changes
Mar 30, 2021
hguthrie
added
2.x
Technical
|
@magento import pr to magento-devdocs/devdocs |
m2-community-project
bot
added
Progress: acceptance testing
and removed
Progress: approved
labels
|
@dobooth the pull request successfully imported. |
|
Hi @BarnyShergold, thank you for your contribution! |
m2-community-project
bot
added
Progress: done
and removed
Progress: acceptance testing
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) fixes #8815
Affected DevDocs pages
https://devdocs.magento.com/cloud/project/magento-env-yaml.html
https://devdocs.magento.com/cloud/live/sens-data-over.html
whatsnew
Added recommendations for improving build and deploy environment definitions related to SCD performance if you have Configuration management enabled.