This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Use "jekyll/jekyll:3.8.6" so it is locked, rather than "latest" #8386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
hguthrie
approved these changes
Dec 14, 2020
hguthrie
added
Technical
|
Hi @Serializator, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
As explained by @hguthrie in #8370, the latest image (
jekyll/jekyll:latest) uses Ruby 2.7.0. Devdocs is using Ruby 2.6.6.By locking the image used in Docker Compose we make sure that it stays on Ruby 2.6.6 rather than unexpectedly use Ruby 2.7.0 (or any other version) because the
latesttag changed.#8370 (comment)
Docker Compose is provided by a contributor as a nice and quick solution to run Devdocs. I do believe that even though it is provided as a "nice and quick" / "nice to have" thing, if you do so it should be maintained as well.
It's a simple and easy change which keeps other developers from being annoyed 🎉 👍