Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

PrivateLink Template Inclusion #8239

Closed
wants to merge 2 commits into from
Closed

PrivateLink Template Inclusion #8239

wants to merge 2 commits into from

Conversation

jpanke
Copy link
Contributor

@jpanke jpanke commented Nov 18, 2020

Purpose of this pull request

This pull request (PR) is to add a new version of the privatelink template for our requestors to add additional clarity to the process of enablement workflow.

Affected DevDocs pages

https://devdocs.magento.com/cloud/project/privatelink-service.html#enablement-workflow

  • ...

File was uploaded to the root of where the pages are. I hope this is acceptable.

Adding a new template file for PrivateLink to help our customers requesting privatelink. This will also get linked from the following page (https://devdocs.magento.com/cloud/project/privatelink-service.html#enablement-workflow).  After this is uploaded will make appropriate change there.
we needed to get a new template file for requesters to use in order to request privatelink with less confusion.  This is a step prior to making a new support form.
@magento-engcom-team
Copy link

@jpanke thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@@ -64,7 +64,7 @@ Enabling PrivateLink can take up to 5 business days. Providing incomplete, or in

### Enablement workflow

The following workflow outlines the enablement process for PrivateLink integration with {{site.data.var.ece}}.
The following workflow outlines the enablement process for PrivateLink integration with {{site.data.var.ece}}. Before you submit your support ticket, please fill out the following excel file with the necessary information. [PrivateLink Information Template] (Excel file you can download, has sample data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following workflow outlines the enablement process for PrivateLink integration with {{site.data.var.ece}}. Before you submit your support ticket, please fill out the following excel file with the necessary information. [PrivateLink Information Template] (Excel file you can download, has sample data)
The following workflow outlines the enablement process for PrivateLink integration with {{site.data.var.ece}}. Before you submit your support ticket, please fill out the following Excel file with the necessary information. [PrivateLink Information Template] (The Excel file, which you can download, has sample data)

Is it correct to do this as an XLS sheet? Two issues - 1. Not everyone uses Excel or can read it 2. People might be concerned about it carrying a virus - what's the stance on these two?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good questions @barny. We do not store these type of binary files in our repo. We recently removed several large binaries that were taking up space in our repo and added them to a downloads/ directory on the site.

Two things come to mind @jpanke:

  • Hosting this file somewhere other than devdocs.magento.com where the internal owners can manage changes would be ideal. That way, we can simply link to it from devdocs and any future changes will be available on devdocs as soon as owners update the linked doc.
  • If hosting elsewhere is not possible, then the file should be converted to PDF that contains a "last modified date" somewhere in the document itself (not the filename) and uploaded to the downloads/ directory by someone on the devdocs-admins team. The source file must be maintained by the owner on internal systems.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant that comment for @BarnyShergold

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did. Sorry about that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S'okay - I still get the email 😄

@jeff-matthews jeff-matthews added the Internal Dev Differentiates work between community and Magento staff label Nov 18, 2020
@jeff-matthews jeff-matthews self-assigned this Nov 18, 2020
@meker12
Copy link
Contributor

meker12 commented Nov 18, 2020

@jeff-matthews, @jpanke Typically, we don't host download files in the DevDocs repo. It's preferable for content to be hosted on a shared Cloud storage location. The easiest would be if the Cloud operations team had a place to host the file that DevDocs can link to. That way, the operations team can update the file as needed. We do have an AWS store that we use for some files, but every time you update the file, it requires a DevDocs ticket (MCLOUD) to upload the file to the file store.

Also, you might consider providing a form instead of a spreadsheet and possibly hosting it through Zendesk or AdobeSign, the way the Launch checklist is provided to customers.

@jeff-matthews
Copy link
Contributor

Yes, @meker12 said it better than I did. Thanks @meker.

@jpanke
Copy link
Contributor Author

jpanke commented Nov 19, 2020

Hey, wanted to comment here. We don't have a place to host the file readily available. We only have this form right now but are working on a ZD form that will replace the excel file once it's in place. We don't expect to have that done for another few months so we need to update our existing one. It was suggested by Director Shane Herman to put it on DevDocs with the very instructions instead of relying manually providing the form.

when we get the ZD form in place we will remove this form and update the instructions.

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpanke, please coordinate with the Support team to host this file on the Magento Help Center. Since this Excel file appears to be a support asset, the Help Center is a more appropriate location for it.

We'd be happy to link to it from devdocs once it's uploaded.

@BarnyShergold
Copy link
Contributor

@jeff-matthews - Author has not made any feedback on this PR. Should we perhaps close this?

@jpanke
Copy link
Contributor Author

jpanke commented Dec 14, 2020

Due to the failure to get the file hosted somewhere, we will look for alternatives and I will make another update to this page later. We are working on getting a new ZD for published instead.

@jpanke jpanke closed this Dec 14, 2020
@ghost
Copy link

ghost commented Dec 14, 2020

Hi @jpanke, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@jeff-matthews
Copy link
Contributor

@magento import code to magento-devdocs/devdocs

@magento-engcom-team
Copy link

@jeff-matthews the branch with code successfully imported intomagento-devdocs/devdocs repository. Branch name: imported-magento-devdocs-8239.

@ghost
Copy link

ghost commented Feb 25, 2021

Hi @jpanke, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Internal Dev Differentiates work between community and Magento staff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants