Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Adding Super Linter #7864

Merged
merged 11 commits into from
Sep 14, 2020
Merged

Adding Super Linter #7864

merged 11 commits into from
Sep 14, 2020

Conversation

dshevtsov
Copy link
Collaborator

@dshevtsov dshevtsov commented Sep 11, 2020 •
edited
Loading

Purpose of this pull request

This pull request (PR):

  • Checks as much of the source code as possible with linters
  • Adds SuperLinter with disabled HTML and Markdown linting
  • Sets the linter to use same triggers as existing Markdown linting test
  • Sets the linter to run only on new or edited files
  • Adds custom configurations for Ruby and Markdown
  • Fixes style in the Ruby and Markdown files
  • Remains the file with Markdown rules reserved for future use (after the bug is fixed) and adds a symlink at the root of project for IDEs that support markdownlint.

Additional information

Markdown linter has false positive failures MD007/ul-indent Unordered list indentation [Expected: 2; Actual: 3]. Looks like a bug.
The project does not contain pure HTML code at source code.

@dshevtsov dshevtsov self-assigned this Sep 11, 2020
@dshevtsov
Copy link
Collaborator Author

Looks like there is some bug in MD linter of the SuperLinter.
It detects false positive violations such as

MD007/ul-indent Unordered list indentation [Expected: 2; Actual: 3]

whereas, in fact, the rule is set to indent: 3

dshevtsov and others added 2 commits September 14, 2020 10:05
@dshevtsov
Disable MD Linter at SuperLinter
1d2d75b 
It detects false positive violation:
MD007/ul-indent Unordered list indentation [Expected: 2; Actual: 3]
@dshevtsov
Fix rubocop offences
c318369 
Use snake_case for file names
@dshevtsov dshevtsov marked this pull request as ready for review September 14, 2020 15:16
jeff-matthews
jeff-matthews approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jus to confirm, two GitHub Actions will run on each PR to a protected branch: 1) MD lint using MDL and 2) Super Linter?

@dshevtsov
Copy link
Collaborator Author

dshevtsov commented Sep 14, 2020 •
edited
Loading

Correct,

  1. MD lint using mdl on entire codebase
  2. Super Linter on new or modified files with all linters enabled except HTML and MD

And only the first option is set as a required check at the moment.

@dshevtsov
Copy link
Collaborator Author

running tests

@dshevtsov dshevtsov merged commit 2359c12 into master Sep 14, 2020
@ghost
Copy link

ghost commented Sep 14, 2020

Hi @dshevtsov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dshevtsov dshevtsov deleted the ds_add-superlinter branch September 14, 2020 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeff-matthews jeff-matthews jeff-matthews approved these changes

Assignees

@dshevtsov dshevtsov

@jeff-matthews jeff-matthews

Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dshevtsov @jeff-matthews