Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

example snippet added for composer.json #6632

Merged
merged 3 commits into from
Feb 13, 2020

Conversation

chandru-199
Copy link
Contributor

Purpose of this pull request

This pull request (PR) - added example snippet for composer.json topic

Affected DevDocs pages

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@keharper
Copy link
Contributor

I'm not committing to doing a full review at this time, but make sure the sample code you're committing is valid. The PHP versions are very outdated.

@chandru-199
Copy link
Contributor Author

chandru-199 commented Feb 13, 2020

Thanks @keharper . I have made changes to the php versions.

@dobooth
Copy link
Contributor

dobooth commented Feb 13, 2020

running tests

@dobooth dobooth merged commit e6dbb4f into magento:master Feb 13, 2020
@ghost
Copy link

ghost commented Feb 13, 2020

Hi @chandru-199, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@chandru-199
Copy link
Contributor Author

Why this PR closed without Any labels?

@jeff-matthews
Copy link
Contributor

Looks like an oversight on our part @chandru-199.

@dobooth, please apply the appropriate label.

@chandru-199
Copy link
Contributor Author

Thanks Jeff....

@keharper keharper added 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc labels Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Partner: Ziffity partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants