This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Added correct sort type for products query in graphql #6627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Ziffity
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
keharper
previously approved these changes
Feb 12, 2020
There was a problem hiding this comment.
@VinothKumar361 I accepted all your changes except for the layered navigation query. In that case, I backed out your change and added a note stating that you must explicitly enable filtering for the color attribute.
keharper
added
2.3.x
|
running tests |
|
@keharper That would be great. Thanks!! |
keharper
approved these changes
Feb 12, 2020
|
running tests |
|
Hi @VinothKumar361, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Adding correct sort type for products query in graphql
Affected DevDocs pages
Links to Magento source code