Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Update deployment flow steps #6439

Merged
merged 5 commits into from
Jan 30, 2020
Merged

Update deployment flow steps #6439

merged 5 commits into from
Jan 30, 2020

Conversation

jeff-matthews
Copy link
Contributor

@jeff-matthews jeff-matthews commented Jan 22, 2020 •
edited
Loading

Purpose of this pull request

This pull request (PR) rearranges sections in the correct order for the recommended deployment flow to prevent compilation errors.

See MC-17501 for more details and link to a staging build

Affected DevDocs pages

@jeff-matthews jeff-matthews added Internal Dev Differentiates work between community and Magento staff Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels Jan 22, 2020
@jeff-matthews jeff-matthews requested a review from kandy January 22, 2020 23:57
hguthrie
hguthrie previously approved these changes Jan 23, 2020
View reviewed changes
src/guides/v2.3/performance-best-practices/deployment-flow.md Outdated Show resolved Hide resolved
@shrielenee shrielenee added the Waiting for Response Waiting for response from internal/external parties label Jan 23, 2020
@jeff-matthews
Copy link
Contributor Author

Thanks for the review @hguthrie!

@kandy, please review when you have a chance.

@jeff-matthews jeff-matthews removed the request for review from keharper January 23, 2020 19:47
@jeff-matthews @hguthrie
Update src/guides/v2.3/performance-best-practices/deployment-flow.md
fe7b349 
Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>
hguthrie
hguthrie previously approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you consider that last comment I made about Setting the production mode, then all looks good.

@jeff-matthews
Copy link
Contributor Author

@kandy, I think we're just waiting for your review on this.

@jeff-matthews jeff-matthews added small changes and removed Waiting for Response Waiting for response from internal/external parties small changes labels Jan 30, 2020
@jeff-matthews
Copy link
Contributor Author

running tests

@jeff-matthews jeff-matthews merged commit a24c020 into master Jan 30, 2020
@ghost
Copy link

ghost commented Jan 30, 2020

Hi @jeff-matthews, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@jeff-matthews jeff-matthews deleted the MC-17501-deploy-flow branch January 30, 2020 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hguthrie hguthrie hguthrie approved these changes

@kandy kandy kandy approved these changes

@fascinosum fascinosum Awaiting requested review from fascinosum

Assignees

@hguthrie hguthrie

@jeff-matthews jeff-matthews

Labels
Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Internal Dev Differentiates work between community and Magento staff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeff-matthews @kandy @hguthrie @fascinosum @shrielenee