Update Code - DocBlock Standard #6255
Conversation
|
An admin must run tests on this PR before it can be merged. |
edenduong
changed the title
|
@jeff-matthews : I have just merge into 1 PR. You can check it. Thanks! |
|
Thanks @edenduong! Coding Standards require review from Magento architects, so I'm adding @buskamuza. |
jeff-matthews
added
2.2.x
2.3.x
|
Hi @edenduong Thanks for the contribution. We recently stopped taking contributions for v2.2, as it is entering EOL. Please update the changes to the v2.3 file. Also, since it is dealing with coding standards, we are asking for architects to review. Thanks. |
| if (Mage::helper('Mage_Core_Helper_File_Storage_Database')->checkDbUsage()) { | ||
| Mage::getModel('Mage_Core_Model_File_Storage_Directory_Database')->deleteDirectory($path); | ||
| if (!$this->isPathAllowed($path, $this->getConditionsForExcludeDirs())) { | ||
| throw new \Magento\Framework\Exception\LocalizedException( |
There was a problem hiding this comment.
This is explicit throwing of an exception. The section is about implicit throwing. An example could be if there would be a method like $this->throwException() or something like this.
There was a problem hiding this comment.
I have change the example. Please check it. Thanks!
|
Hi @edenduong Any update on this PR? |
|
@edenduong Still out there? Any updates? |
edenduong
force-pushed
the
code_standard_demarcation_update_magento2
branch
from
547c4cd to
426a3a1
Compare
edenduong
changed the title
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
|
@dobooth: Sorry for late response. I have just change the docs. |
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
|
running tests |
|
Hi @edenduong, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) will remove the Old Magento 1 code in the DocBlock Standard Page.
Update to Magento 2 code.
Affected DevDocs pages
Links to Magento source code