Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Fixed code format issue #5833

Merged
merged 3 commits into from
Oct 28, 2019
Merged

Conversation

yogeshsuhagiya
Copy link
Member

Purpose of this pull request

  • Corrected the <code> format issue.
  • Removed un-necessary spaces

Affected DevDocs pages

Links to Magento source code

  • N/A

Screenshot:

screenshot-devdocs magento com-2019 10 24-13_07_03

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@osrecio
Copy link
Member

osrecio commented Oct 24, 2019

Hi @yogeshsuhagiya, thanks for your PR,

Can you take advantage of this PR, to make the table Markdown style? Will very useful.

Thanks!

@yogeshsuhagiya
Copy link
Member Author

yogeshsuhagiya commented Oct 24, 2019

Hi @osrecio,
Will you please share some examples for table Markdown style?

@osrecio
Copy link
Member

osrecio commented Oct 24, 2019

@hickskenh
Copy link
Contributor

hickskenh commented Oct 24, 2019

the fixed file has 2 close code commands. needs to be fixed when the table is converted to markdown.
image

@yogeshsuhagiya
Copy link
Member Author

the fixed file has 2 close code commands. needs to be fixed when the table is converted to markdown.
image

Removed multiple close code commands.

@yogeshsuhagiya
Copy link
Member Author

Hi @osrecio, I've updated PR as per your guidance, will you please take a look?

@dobooth dobooth added 2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels Oct 28, 2019
@dobooth
Copy link
Contributor

dobooth commented Oct 28, 2019

running tests

@dobooth dobooth merged commit 5efcdc8 into magento:master Oct 28, 2019
@ghost
Copy link

ghost commented Oct 28, 2019

Hi @yogeshsuhagiya, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants