This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Enable linting rule MD032 (blank lines around lists) #5415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-matthews
added
the
Site Improvements
Updates to tools, processes, and site architecture that improve reader and contributor experience
label
Sep 18, 2019
I turned off the rule. We can merge this PR pending approval. |
hguthrie
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added one note about a section that was deleted. I agree with the deletion, but there is an open bug ticket on that very section. I wasn't sure how to handle it, which it why I created the bug.
running tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Site Improvements
Updates to tools, processes, and site architecture that improve reader and contributor experience
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) enables rule MD032, which requires blank lines around lists.
Related to #5250
Additional info
This PR fixes a majority of issues, but there are still 38 errors:
The cloud errors are interesting because the reported issue is inside a fenced code block and is considered a false positive because it's intended to be terminal output.
The MRG errors must be fixed in the source READMEs; not in devdocs.
I propose reverting the change in this PR that enables the rule, but merging all the other fixes while we fix the MRG READMEs and address the outstanding cloud issue.