This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
[New Topic] Added documentation for "sticky" widget #5371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
jeff-matthews
added
the
New Topic
rogyar
suggested changes
Sep 12, 2019
| ### `container` {#s_option_container} | ||
|
|
||
| Element selector, who's height will be used to restrict the maximum offsetTop | ||
| position of the stuck element. Default uses document `body`. |
There was a problem hiding this comment.
Is it "stuck" element? Maybe we should name it as "sticky"? :) We can say "stuck" but it sounds like something is not quite right with the element.
There was a problem hiding this comment.
Basically, the same point is fair for all other occurrences in the document
rogyar
added
2.2.x
2.3.x
|
Hi @rogyar, |
rogyar
approved these changes
Sep 13, 2019
|
running tests |
meker12
removed
the
Technical
|
Hi @meker12 , |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds documentation for "Sticky" widget
Affected DevDocs pages
https://devdocs.magento.com/guides/v2.3/javascript-dev-guide/widgets/widget_sticky.html
Links to Magento source code
whatsnew
Added the Sticky widget topic to the Javascript Developer Guide.