Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Fixing the shared parameter default value #4921

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Fixing the shared parameter default value #4921

merged 1 commit into from
Jul 10, 2019

Conversation

eduard13
Copy link
Contributor

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Jul 10, 2019
@rogyar rogyar added 2.2.x 2.3.x Magento 2.3 related changes labels Jul 10, 2019
@rogyar
Copy link
Contributor

rogyar commented Jul 10, 2019

From a technical standpoint, this change is correct. If the shared parameter is not set, the following part of the logic https://github.com/magento/magento2/blob/adb5dff9c2cf5b158df51f0efdf788047645b7c6/lib/internal/Magento/Framework/Event/Invoker/InvokerDefault.php#L72
Will get the existing observer instance instead of creating a new one.

@dobooth dobooth added the Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies label Jul 10, 2019
@dobooth dobooth changed the base branch from master to small_changes July 10, 2019 13:15
@dobooth dobooth merged commit 4361b11 into magento:small_changes Jul 10, 2019
@ghost
Copy link

ghost commented Jul 10, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth mentioned this pull request Jul 10, 2019
Merged
@eduard13 eduard13 deleted the patch-4894-issue branch July 27, 2019 06:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

Labels
2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eduard13 @devops-devdocs @rogyar @magento-engcom-team @dobooth