This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
MAGEDOC-3840: Remove 2.1 docs #4917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l with page.baseurl
…ks using page.baseurl
jeff-matthews
added
Internal Dev
jeff-matthews
requested review from
dshevtsov,
belbiy,
hguthrie,
jcalcaben,
meker12,
dobooth and
a team
|
I couldn't get any unexpected results to happen. It might be outside the scope of this PR, but there are still plenty of references to "2.1" and even "2.0" in the TOC file. |
|
Thanks for the review @keharper. Re: 2.0 and 2.1 references in the TOC, this came up when we removed 2.0 docs. At the time, we decided to leave them because it wasn't causing any adverse effects and if we ever need to build old versions of the docs, we'll need those references. |
dobooth
reviewed
Jul 10, 2019
dobooth
approved these changes
Jul 10, 2019
hguthrie
suggested changes
Jul 10, 2019
Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>
Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>
|
Thanks for the review @hguthrie! |
meker12
approved these changes
Jul 10, 2019
meker12
reviewed
Jul 10, 2019
hguthrie
approved these changes
Jul 11, 2019
Co-Authored-By: Margaret Eker <meker@adobe.com>
|
running tests |
|
Hi @jeff-matthews, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) removes all
guides/v2.1content from the devdocs site since 2.1 reached end-of-life (EOL) on 6/30/19 and no longer receives security patches, quality fixes, or documentation updates.This PR also removes all 2.1 redirect metadata since we're going to implement an S3-based redirect that does the following:
If a 2.3 file exists for an incoming 2.1 URL, S3 will redirect to that page. For example:
Will redirect to:
If a 2.3 file does not exist for an incoming 2.1 URL, S3 will redirect to the home page of the latest version of devdocs (currently 2.3). For example:
Will redirect to:
Incidentally, this config eliminates the possibility of getting a 404 on 2.3 pages in most cases.
Additional info