Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Added warning to Migrate settings about develop mode. #4906

Merged
merged 6 commits into from
Jul 10, 2019

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Jul 8, 2019

Purpose of this pull request

This pull request (PR) adds a warning about setting develop mode when migrating data.
This replaces #3771

Affected DevDocs pages

@dobooth dobooth added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies 2.2.x 2.3.x Magento 2.3 related changes labels Jul 8, 2019
@dobooth dobooth self-assigned this Jul 8, 2019
@dobooth dobooth requested a review from shrielenee July 8, 2019 20:26
Copy link
Contributor

@shrielenee shrielenee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with changes

guides/v2.2/migration/migration-migrate-settings.md Outdated Show resolved Hide resolved
guides/v2.2/migration/migration-migrate-settings.md Outdated Show resolved Hide resolved
@@ -20,13 +20,18 @@ According to our data migration [order]({{ page.baseurl }}/migration/migration-m

2. Change to the Magento `/bin` directory or make sure it is added to your system PATH.

{: .bs-callout .bs-callout-info }
Make sure Magento is deployed in default mode. Developer mode can cause validation errors in the migration tool.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ensure" again.


5. Specify the new name of the settings file for mapping. To do that, change the `<settings_map_file>` tag in the `path/to/config.xml` file.
1. Specify the new name of the settings file for mapping. To do that, change the `<settings_map_file>` tag in the `path/to/config.xml` file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment about this phrasing.

@dobooth
Copy link
Contributor Author

dobooth commented Jul 10, 2019

running tests

@dobooth dobooth merged commit 80e2003 into master Jul 10, 2019
@ghost
Copy link

ghost commented Jul 10, 2019

Hi @dobooth, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the db_migratesettings branch July 10, 2019 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants