Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

MAGECLOUD-3193 github integration #3843

Merged
merged 3 commits into from
Mar 1, 2019
Merged

Conversation

hguthrie
Copy link
Contributor

@hguthrie hguthrie commented Feb 28, 2019

Bug fix

  • Updated the GitHub Integration topic to add a that warning this overwrites everything.

  • Updated the GitHub Integration topic to align with the latest GitHub interface.

  • Removed old, incorrect graphics. Unfortunately, this required an update to a 2.0 topic to avoid a broken link.

  • Cleaned the formatting for the steps and made more consistent with other integration topics, such as Bitbucket.

  • Requires a technical review pass

whatsnew
Updated the GitHub integration topic.

@hguthrie hguthrie added the Technical Updates to the code or processes that alter the technical content of the doc label Feb 28, 2019
@hguthrie hguthrie self-assigned this Feb 28, 2019
@hguthrie hguthrie added 2.x Internal Dev Differentiates work between community and Magento staff labels Mar 1, 2019
@hguthrie
Copy link
Contributor Author

hguthrie commented Mar 1, 2019

running tests

@hguthrie hguthrie merged commit 1e645d1 into master Mar 1, 2019
@ghost
Copy link

ghost commented Mar 1, 2019

Hi @hguthrie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dshevtsov
Copy link
Collaborator

dshevtsov commented Mar 4, 2019

@hguthrie please remove a leading space for url of hyperlink at whatsnew.

@hguthrie hguthrie deleted the hg-mc3193-githubintegration branch March 5, 2019 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants