Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Remove reference to the sample Magento_SamplePaymentGateway module #7958

Closed
kananinj opened this issue Sep 30, 2020 · 6 comments
Closed

Remove reference to the sample Magento_SamplePaymentGateway module #7958

kananinj opened this issue Sep 30, 2020 · 6 comments
Assignees
Labels
2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Progress: done

Comments

@kananinj
Copy link

kananinj commented Sep 30, 2020

General issue

Affected topic: /guides/v2.3/payments-integrations/base-integration/module-configuration.html

Description:

In magento 2 sample payment gateway module link not found on github

Possible solutions:

Additional information:

@m2-assistant
Copy link

m2-assistant bot commented Sep 30, 2020

Hi @kananinj. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@keharper keharper added 2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels Oct 1, 2020
@keharper keharper changed the title Feedback on page: /guides/v2.3/payments-integrations/base-integration/module-configuration.html Remove reference to the sample Magento_SamplePaymentGateway module Oct 1, 2020
@gelanivishal
Copy link
Contributor

Hi @keharper, Need to remove this line from docs or any other solution?

@keharper
Copy link
Contributor

@gelanivishal @kananinj and anyone else watching.

We have multiple links to the magento-samples repo, which has been made private. There is no plan to make the repo pubic again. We have to research whether we can add limited code samples in topics that reference the repo, delete the references, or delete the entire topic.

@jeff-matthews
Copy link
Contributor

I started a wiki page to track our decision making process: https://github.com/magento/devdocs/wiki/Archived-code-samples

@kananinj
Copy link
Author

kananinj commented Nov 9, 2020

@gelanivishal
now it public repository..
https://github.com/magento/magento2-samples

i hope its good for us.

@jeff-matthews
Copy link
Contributor

Thanks @kananinj! Confirmed that the repo is publicly accessible again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Progress: done
Projects
None yet
Development

No branches or pull requests

5 participants