Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sp] add right click context menu #661

Merged
merged 8 commits into from
Jul 16, 2022
Merged

[sp] add right click context menu #661

merged 8 commits into from
Jul 16, 2022

Conversation

shrey-mage
Copy link
Contributor

@shrey-mage shrey-mage commented Jul 15, 2022 •
edited
Loading

Summary

  • build generic right click context menu for use throughout data prep tool
  • add context menu to the file browser (currently, the only action supported is deleting block files)
  • display error popup box if user tries to delete a block file with dependencies

Tests

2022-07-15 16 28 26

cc: @johnson-mage

@shrey-mage shrey-mage self-assigned this Jul 15, 2022
@shrey-mage shrey-mage requested a review from johnson-mage July 15, 2022 23:29
@shrey-mage shrey-mage marked this pull request as ready for review July 15, 2022 23:30
@johnson-mage
Copy link
Member

The context menu with only a "Delete" menu seems a bit large. Can we reduce the width a bit?

johnson-mage
johnson-mage approved these changes Jul 16, 2022
View reviewed changes
Copy link
Member

@johnson-mage johnson-mage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved after addressing comments

@shrey-mage
Copy link
Contributor Author

The context menu with only a "Delete" menu seems a bit large. Can we reduce the width a bit?

@johnson-mage added a compact prop to FlyoutMenu that makes the min width UNIT * 20:

image

@shrey-mage shrey-mage merged commit 78f3c8f into master Jul 16, 2022
@shrey-mage shrey-mage deleted the sp--add-right-click-menu branch July 16, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnson-mage johnson-mage johnson-mage approved these changes

Assignees

@shrey-mage shrey-mage

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrey-mage @johnson-mage