Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sk] Updated data IO templates for ease of use #660

Merged
merged 2 commits into from
Jul 15, 2022
Merged

[sk] Updated data IO templates for ease of use #660

merged 2 commits into from
Jul 15, 2022

Conversation

skunichetty
Copy link
Contributor

Summary

Made two main modifications:

  • For file IO, dropped configuration settings in favor of reading filepath
  • For other IO methods, updated comments to refer to configuration settings in io_config.yaml

Tests

Unit tests updated to check newest templates are loaded correctly

@skunichetty skunichetty merged commit 13cb0a4 into master Jul 15, 2022
@skunichetty skunichetty deleted the sk--update_data_loader_templates branch July 15, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangxiaoyou1993 wangxiaoyou1993 wangxiaoyou1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skunichetty @wangxiaoyou1993