[sk] Improved PostgreSQL Data Loader #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
July 13, 2022 21:46
skunichetty
changed the title
mage_ai/io/postgres.py
Outdated
| df: DataFrame, | ||
| table_name: str, | ||
| index: bool = False, | ||
| if_exists: str = 'replace', |
There was a problem hiding this comment.
nit: let's create constants/enum for the options
mage_ai/io/postgres.py
Outdated
| from mage_ai.io.export_utils import ( | ||
| BadConversionError, | ||
| clean_df_for_export, | ||
| PandasTypes, |
| self, df: DataFrame, name: str, index: bool = False, if_exists: str = 'replace', **kwargs | ||
| self, | ||
| df: DataFrame, | ||
| table_name: str, |
There was a problem hiding this comment.
I think you also need to specify schema_name to identify a table.
There was a problem hiding this comment.
Forgot about schemas, added schema_name parameter + auto creation of schema if the given schema doesn't exist.
mage_ai/io/postgres.py
Outdated
| ) | ||
| self.conn.commit() | ||
|
|
||
| def __table_exists(self, table_name: str) -> bool: |
There was a problem hiding this comment.
same here. you need both schema_name and table_name to identify a table.
There was a problem hiding this comment.
Added schema name to table existence check.
wangxiaoyou1993
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the PostgreSQL IO handler to avoid using SQLAlchemy. There are a few benefits to this change:
The change made was to use PostgreSQLs
COPY TOquery to improve export times in place ofpandas.DataFrame.to_sql(). To do this, a new framework was added to manage type conversion (mapping Pandas datatypes to PostgreSQL data types). This framework involves:np.timedelta64has no appropriate type in PostgreSQL, so it is mapped to an integer before exporting)Tests
Changes tested locally with PostgreSQL database alongside unit tests.
cc
@wangxiaoyou1993 @dy46