Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README Cleanup "Working with dynamically inserted and removed steps" #290

Merged
merged 1 commit into from
May 9, 2020
Merged

README Cleanup "Working with dynamically inserted and removed steps" #290

merged 1 commit into from
May 9, 2020

Conversation

madoar
Copy link
Owner

@madoar madoar commented May 3, 2020 •
edited by gitpod-io bot
Loading

This PR cleans up the section Working with dynamically inserted and removed steps in the README file.

To be more specific this PR removes the deprecated information that a ChangeDetectorRef#detectChanges call may be necessary in the afterViewInit lifecycle method.

@madoar madoar merged commit ea5d6a1 into develop May 9, 2020
@madoar madoar deleted the fix/unnecessary-detect-changes branch May 9, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@madoar