Add StepId and StepIndex interfaces #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change the way the goToStep directive takes a step index - add a way to navigate to a step by its unique id
- split goToStep directive tests into different test case files for for the StepOffset, StepIndex and StepId interfaces
- add StepId and StepIndex to the index.ts file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
StepIdandStepIndexinterface tong2-archwizard.Both interfaces can be passed to the
awGoToStepdirective as input arguments.The
StepIdinterface enables the wizard to navigate to a step by its unique id, which can be set via thestepIdinput, which all wizard steps support now.In addition this PR does a bit of refactoring, which includes moving some tests to new test files for the
StepId,StepIndexandStepOffsetinterfaces.Closes #83