fix: `invalid culture identifier` #88

skyzh · 2022-01-13T04:57:35Z

After GitHub bumps .NET version of actions runner, our EC2 runner reports:

System.Globalization.CultureNotFoundException: Only the invariant culture is supported in globalization-invariant mode. See https://aka.ms/GlobalizationInvariantMode for more information. (Parameter 'name')
en-US is an invalid culture identifier.
   at System.Globalization.CultureInfo..ctor(String name, Boolean useUserOverride)
   at System.Globalization.CultureInfo..ctor(String name)
   at GitHub.Runner.Common.HostContext.SetDefaultCulture(String name)
   at GitHub.Runner.Worker.Worker.SetCulture(AgentJobRequestMessage message)
   at GitHub.Runner.Worker.Worker.RunAsync(String pipeIn, String pipeOut)
   at GitHub.Runner.Worker.Program.MainAsync(IHostContext context, String[] args)

And from this issue actions/runner#1605, it seems that we should remove DOTNET_SYSTEM_GLOBALIZATION_INVARIANT.

I'm still testing with this change, not sure if this really works. Thanks for reviewing!

davinchia · 2022-01-13T05:01:09Z

@skyzh we are running into this as well - pls keep me updated.

Signed-off-by: Alex Chi <iskyzh@gmail.com>

skyzh · 2022-01-13T05:35:34Z

Hi @davinchia, my forked action works perfectly in our environment. To use it for now, simply apply the following snippet in the GitHub Action config.

uses: skyzh/ec2-github-runner@ba2298a67875dfdd29a88fafbc1ba27f4f94af39

After this PR gets merged, or GitHub staff reverts the action .NET runtime, you can change back to machulav/ec2-github-runner@v2.

davinchia · 2022-01-13T05:36:09Z

amazing, let me give it a shot

davinchia · 2022-01-13T05:55:52Z

@skyzh works for us - thanks so much again!

skyzh · 2022-01-13T05:56:55Z

Hi @machulav, would you please take a look if you have time? Thanks!

Due to actions/runner#1605, all our builds are failing. This changes pins us to machulav/ec2-github-runner#88 until a more stable solution is available. Either the upstream action merges this in and we bump our version, or Github reverts their breaking change.

IceTDrinker · 2022-01-13T14:53:18Z

is this action still getting support/being developed ?

Edit: maybe let me rephrase it seems there has not been a new commit since August last year and the latest github internal upgrade broke the action, is it recommended to fork and use our fork ?

machulav · 2022-01-13T21:23:19Z

Let me make some final tests and I will merge if everything works.

machulav · 2022-01-13T21:57:52Z

Merged. The machulav/ec2-github-runner@v2 already contains the fix.

@skyzh @ramosbugs thanks a lot for figuring that out and for the fix!

* fix: `invalid culture identifier` (machulav#88) * remove `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` * build index.js Signed-off-by: Alex Chi <iskyzh@gmail.com> * Version updates (machulav#92) * Update runner version * Update package-lock.json * Update dist Co-authored-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: Volodymyr Machula <machulav@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az238-896.lrtv1j1tcsgurjp4mtmc3vvjre.gx.internal.cloudapp.net>

* Use the paginate API call to get all runners instead of just the first page. (machulav#51) * Update dist * Bump glob-parent from 5.1.1 to 5.1.2 (machulav#47) Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix PR automation, update the action version in the example (machulav#54) * Update tag in the example * Remove package from the PR automations * Allow user to pass in a custom actions-runner directory (machulav#56) * Allow user to pass in a custom actions-runner directory which contains pre-installed runner software and scripts * Add comment * Fix input refs * Fix linter error * Update dist * Update the runner version to the latest one (machulav#67) * Update dist * fix: `invalid culture identifier` (machulav#88) * remove `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` * build index.js Signed-off-by: Alex Chi <iskyzh@gmail.com> * Version updates (machulav#92) * Update runner version * Update package-lock.json * Update dist * Add link for donation to help Ukraine protect itself from russian occupants * Update donation URL * Update wordings * Bump @actions/core from 1.6.0 to 1.9.1 (machulav#109) Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.6.0 to 1.9.1. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) --- updated-dependencies: - dependency-name: "@actions/core" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dist * Bump node-fetch from 2.6.6 to 2.6.7 (machulav#105) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.6 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.6...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dist * bump to node16 in action.yml * lint error * update dist file * Revert "update dist file" This reverts commit fa73d35. * use buildUserDataScript and remove trailing comma Signed-off-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az93-126.zwmoqlwq51iuvls2zdlc0jzybe.xx.internal.cloudapp.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Volodymyr Machula <machulav@gmail.com> Co-authored-by: Jukka Palomäki <jukka.palomaki@paf.com> Co-authored-by: GitHub Actions <runner@fv-az90-268.oknmvzgco44exlvyi5fejcivhg.gx.internal.cloudapp.net> Co-authored-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az238-896.lrtv1j1tcsgurjp4mtmc3vvjre.gx.internal.cloudapp.net> Co-authored-by: GitHub Actions <runner@fv-az335-98.st3fsr2bvbpu5iwsufzt3hrohh.gx.internal.cloudapp.net> Co-authored-by: GitHub Actions <runner@fv-az502-646.yzlryxntam3u3auahceqrxiktg.dx.internal.cloudapp.net>

* Use the paginate API call to get all runners instead of just the first page. (machulav#51) * Update dist * Bump glob-parent from 5.1.1 to 5.1.2 (machulav#47) Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix PR automation, update the action version in the example (machulav#54) * Update tag in the example * Remove package from the PR automations * Allow user to pass in a custom actions-runner directory (machulav#56) * Allow user to pass in a custom actions-runner directory which contains pre-installed runner software and scripts * Add comment * Fix input refs * Fix linter error * Update dist * Update the runner version to the latest one (machulav#67) * Update dist * fix: `invalid culture identifier` (machulav#88) * remove `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` * build index.js Signed-off-by: Alex Chi <iskyzh@gmail.com> * Version updates (machulav#92) * Update runner version * Update package-lock.json * Update dist * Add link for donation to help Ukraine protect itself from russian occupants * Update donation URL * Update wordings * Bump @actions/core from 1.6.0 to 1.9.1 (machulav#109) Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.6.0 to 1.9.1. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) --- updated-dependencies: - dependency-name: "@actions/core" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dist * Bump node-fetch from 2.6.6 to 2.6.7 (machulav#105) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.6 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.6...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dist * Fix deprecation warnings (machulav#123) * Update node version * Update version of packages * Update version of runner * Update version of actions * Update dist * Add required package to the documentation * Add 'pre-runner-script' option (machulav#154) Add a 'pre-runner-script' option to specify arbitrary bash commands to run before the runner starts up on the instance. This is useful if you need to install dependencies or have OS-specific setup steps. For example: - name: Start EC2 runner with: mode: start ec2-image-id: ami-07bdb09c49774f92e pre-runner-script: | sudo yum update -y && \ sudo yum install docker git libicu -y \ sudo systemctl enable docker Signed-off-by: Tony Hutter <hutter2@llnl.gov> * Compile dist * Removing dist --------- Signed-off-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az93-126.zwmoqlwq51iuvls2zdlc0jzybe.xx.internal.cloudapp.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Volodymyr Machula <machulav@gmail.com> Co-authored-by: Jukka Palomäki <jukka.palomaki@paf.com> Co-authored-by: GitHub Actions <runner@fv-az90-268.oknmvzgco44exlvyi5fejcivhg.gx.internal.cloudapp.net> Co-authored-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az238-896.lrtv1j1tcsgurjp4mtmc3vvjre.gx.internal.cloudapp.net> Co-authored-by: GitHub Actions <runner@fv-az335-98.st3fsr2bvbpu5iwsufzt3hrohh.gx.internal.cloudapp.net> Co-authored-by: GitHub Actions <runner@fv-az502-646.yzlryxntam3u3auahceqrxiktg.dx.internal.cloudapp.net> Co-authored-by: Tony Hutter <hutter2@llnl.gov>

* Use the paginate API call to get all runners instead of just the first page. (machulav#51) * Update dist * Bump glob-parent from 5.1.1 to 5.1.2 (machulav#47) Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix PR automation, update the action version in the example (machulav#54) * Update tag in the example * Remove package from the PR automations * Allow user to pass in a custom actions-runner directory (machulav#56) * Allow user to pass in a custom actions-runner directory which contains pre-installed runner software and scripts * Add comment * Fix input refs * Fix linter error * Update dist * Update the runner version to the latest one (machulav#67) * Update dist * fix: `invalid culture identifier` (machulav#88) * remove `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` * build index.js Signed-off-by: Alex Chi <iskyzh@gmail.com> * Version updates (machulav#92) * Update runner version * Update package-lock.json * Update dist * Add link for donation to help Ukraine protect itself from russian occupants * Update donation URL * Update wordings * Bump @actions/core from 1.6.0 to 1.9.1 (machulav#109) Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.6.0 to 1.9.1. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) --- updated-dependencies: - dependency-name: "@actions/core" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dist * Bump node-fetch from 2.6.6 to 2.6.7 (machulav#105) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.6 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.6...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dist * Fix deprecation warnings (machulav#123) * Update node version * Update version of packages * Update version of runner * Update version of actions * Update dist * Add required package to the documentation * Add 'pre-runner-script' option (machulav#154) Add a 'pre-runner-script' option to specify arbitrary bash commands to run before the runner starts up on the instance. This is useful if you need to install dependencies or have OS-specific setup steps. For example: - name: Start EC2 runner with: mode: start ec2-image-id: ami-07bdb09c49774f92e pre-runner-script: | sudo yum update -y && \ sudo yum install docker git libicu -y \ sudo systemctl enable docker Signed-off-by: Tony Hutter <hutter2@llnl.gov> * Compile dist * Removing dist * Add back dist --------- Signed-off-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az93-126.zwmoqlwq51iuvls2zdlc0jzybe.xx.internal.cloudapp.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Volodymyr Machula <machulav@gmail.com> Co-authored-by: Jukka Palomäki <jukka.palomaki@paf.com> Co-authored-by: GitHub Actions <runner@fv-az90-268.oknmvzgco44exlvyi5fejcivhg.gx.internal.cloudapp.net> Co-authored-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az238-896.lrtv1j1tcsgurjp4mtmc3vvjre.gx.internal.cloudapp.net> Co-authored-by: GitHub Actions <runner@fv-az335-98.st3fsr2bvbpu5iwsufzt3hrohh.gx.internal.cloudapp.net> Co-authored-by: GitHub Actions <runner@fv-az502-646.yzlryxntam3u3auahceqrxiktg.dx.internal.cloudapp.net> Co-authored-by: Tony Hutter <hutter2@llnl.gov>

* remove `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` * build index.js Signed-off-by: Alex Chi <iskyzh@gmail.com>

remove DOTNET_SYSTEM_GLOBALIZATION_INVARIANT

096d90a

build index.js

ba2298a

Signed-off-by: Alex Chi <iskyzh@gmail.com>

skyzh changed the title ~~remove DOTNET_SYSTEM_GLOBALIZATION_INVARIANT~~ fix: invalid culture identifier Jan 13, 2022

davinchia mentioned this pull request Jan 13, 2022

Patch Github Runner build. airbytehq/airbyte#9466

Merged

40 tasks

philschmid mentioned this pull request Jan 13, 2022

Bump runner version to 2.286.0 #89

Closed

machulav linked an issue Jan 13, 2022 that may be closed by this pull request

Hello World Job Completes With a Failed Result on the EC2 Instance #91

Closed

machulav merged commit 7f0f481 into machulav:main Jan 13, 2022

mmoriani pushed a commit to ottimis/ec2-github-runner that referenced this pull request Feb 15, 2024

fix: invalid culture identifier (machulav#88)

693a2fd

* remove `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` * build index.js Signed-off-by: Alex Chi <iskyzh@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: `invalid culture identifier` #88

fix: `invalid culture identifier` #88

skyzh commented Jan 13, 2022

davinchia commented Jan 13, 2022

skyzh commented Jan 13, 2022

davinchia commented Jan 13, 2022

davinchia commented Jan 13, 2022

skyzh commented Jan 13, 2022

IceTDrinker commented Jan 13, 2022 •

edited

Loading

machulav commented Jan 13, 2022

machulav commented Jan 13, 2022

fix: invalid culture identifier #88

fix: invalid culture identifier #88

Conversation

skyzh commented Jan 13, 2022

davinchia commented Jan 13, 2022

skyzh commented Jan 13, 2022

davinchia commented Jan 13, 2022

davinchia commented Jan 13, 2022

skyzh commented Jan 13, 2022

IceTDrinker commented Jan 13, 2022 • edited Loading

machulav commented Jan 13, 2022

machulav commented Jan 13, 2022

fix: `invalid culture identifier` #88

fix: `invalid culture identifier` #88

IceTDrinker commented Jan 13, 2022 •

edited

Loading