Properly paginate runner lists call. #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@machulav I don't see any tests here. Let me know what kind of tests I should figure out as part of this PR. |
jaredmdobson
approved these changes
Jun 25, 2021
|
@jaredmdobson any idea what it would take to merge this in? I'm very eager to use this in our builds! |
|
@davinchia, many thanks for your contribution and sorry for the late reply. I've merged your PR to master so that you can use it from the master branch for now. A bit later, I will make a new version with this fix. |
|
Thanks @machulav ! What action version do I specify to use the version at master? |
|
@davinchia For now, you can use |
|
thank you @machulav - please let me know when you do a new release! |
26 tasks
davinchia
added a commit
to airbytehq/airbyte
that referenced
this pull request
Jun 29, 2021
Fix a bug in ec2 runner that I committed to the underlying library in machulav/ec2-github-runner#51. This points to master because the action's maintainer has yet to release a version. I'll move it to a proper version when one is released.
|
@davinchia I've added a new version v2.2.1 that contains your fix. In addition, I've added a version v2 which tracks the latest v2.x.x release. So you can now use Thank you again for your contribution! 🙏 |
johnsonrw82
pushed a commit
to physion/ec2-github-runner
that referenced
this pull request
Oct 27, 2022
* Use the paginate API call to get all runners instead of just the first page. (machulav#51) * Update dist * Bump glob-parent from 5.1.1 to 5.1.2 (machulav#47) Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix PR automation, update the action version in the example (machulav#54) * Update tag in the example * Remove package from the PR automations * Allow user to pass in a custom actions-runner directory (machulav#56) * Allow user to pass in a custom actions-runner directory which contains pre-installed runner software and scripts * Add comment * Fix input refs * Fix linter error * Update dist * Update the runner version to the latest one (machulav#67) * Update dist * fix: `invalid culture identifier` (machulav#88) * remove `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` * build index.js Signed-off-by: Alex Chi <iskyzh@gmail.com> * Version updates (machulav#92) * Update runner version * Update package-lock.json * Update dist * Add link for donation to help Ukraine protect itself from russian occupants * Update donation URL * Update wordings * Bump @actions/core from 1.6.0 to 1.9.1 (machulav#109) Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.6.0 to 1.9.1. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) --- updated-dependencies: - dependency-name: "@actions/core" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dist * Bump node-fetch from 2.6.6 to 2.6.7 (machulav#105) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.6 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.6...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dist * bump to node16 in action.yml * lint error * update dist file * Revert "update dist file" This reverts commit fa73d35. * use buildUserDataScript and remove trailing comma Signed-off-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az93-126.zwmoqlwq51iuvls2zdlc0jzybe.xx.internal.cloudapp.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Volodymyr Machula <machulav@gmail.com> Co-authored-by: Jukka Palomäki <jukka.palomaki@paf.com> Co-authored-by: GitHub Actions <runner@fv-az90-268.oknmvzgco44exlvyi5fejcivhg.gx.internal.cloudapp.net> Co-authored-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az238-896.lrtv1j1tcsgurjp4mtmc3vvjre.gx.internal.cloudapp.net> Co-authored-by: GitHub Actions <runner@fv-az335-98.st3fsr2bvbpu5iwsufzt3hrohh.gx.internal.cloudapp.net> Co-authored-by: GitHub Actions <runner@fv-az502-646.yzlryxntam3u3auahceqrxiktg.dx.internal.cloudapp.net>
johnsonrw82
added a commit
to physion/ec2-github-runner
that referenced
this pull request
Dec 7, 2023
* Use the paginate API call to get all runners instead of just the first page. (machulav#51) * Update dist * Bump glob-parent from 5.1.1 to 5.1.2 (machulav#47) Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix PR automation, update the action version in the example (machulav#54) * Update tag in the example * Remove package from the PR automations * Allow user to pass in a custom actions-runner directory (machulav#56) * Allow user to pass in a custom actions-runner directory which contains pre-installed runner software and scripts * Add comment * Fix input refs * Fix linter error * Update dist * Update the runner version to the latest one (machulav#67) * Update dist * fix: `invalid culture identifier` (machulav#88) * remove `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` * build index.js Signed-off-by: Alex Chi <iskyzh@gmail.com> * Version updates (machulav#92) * Update runner version * Update package-lock.json * Update dist * Add link for donation to help Ukraine protect itself from russian occupants * Update donation URL * Update wordings * Bump @actions/core from 1.6.0 to 1.9.1 (machulav#109) Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.6.0 to 1.9.1. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) --- updated-dependencies: - dependency-name: "@actions/core" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dist * Bump node-fetch from 2.6.6 to 2.6.7 (machulav#105) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.6 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.6...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dist * Fix deprecation warnings (machulav#123) * Update node version * Update version of packages * Update version of runner * Update version of actions * Update dist * Add required package to the documentation * Add 'pre-runner-script' option (machulav#154) Add a 'pre-runner-script' option to specify arbitrary bash commands to run before the runner starts up on the instance. This is useful if you need to install dependencies or have OS-specific setup steps. For example: - name: Start EC2 runner with: mode: start ec2-image-id: ami-07bdb09c49774f92e pre-runner-script: | sudo yum update -y && \ sudo yum install docker git libicu -y \ sudo systemctl enable docker Signed-off-by: Tony Hutter <hutter2@llnl.gov> * Compile dist * Removing dist --------- Signed-off-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az93-126.zwmoqlwq51iuvls2zdlc0jzybe.xx.internal.cloudapp.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Volodymyr Machula <machulav@gmail.com> Co-authored-by: Jukka Palomäki <jukka.palomaki@paf.com> Co-authored-by: GitHub Actions <runner@fv-az90-268.oknmvzgco44exlvyi5fejcivhg.gx.internal.cloudapp.net> Co-authored-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az238-896.lrtv1j1tcsgurjp4mtmc3vvjre.gx.internal.cloudapp.net> Co-authored-by: GitHub Actions <runner@fv-az335-98.st3fsr2bvbpu5iwsufzt3hrohh.gx.internal.cloudapp.net> Co-authored-by: GitHub Actions <runner@fv-az502-646.yzlryxntam3u3auahceqrxiktg.dx.internal.cloudapp.net> Co-authored-by: Tony Hutter <hutter2@llnl.gov>
johnsonrw82
added a commit
to physion/ec2-github-runner
that referenced
this pull request
Dec 7, 2023
* Use the paginate API call to get all runners instead of just the first page. (machulav#51) * Update dist * Bump glob-parent from 5.1.1 to 5.1.2 (machulav#47) Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix PR automation, update the action version in the example (machulav#54) * Update tag in the example * Remove package from the PR automations * Allow user to pass in a custom actions-runner directory (machulav#56) * Allow user to pass in a custom actions-runner directory which contains pre-installed runner software and scripts * Add comment * Fix input refs * Fix linter error * Update dist * Update the runner version to the latest one (machulav#67) * Update dist * fix: `invalid culture identifier` (machulav#88) * remove `DOTNET_SYSTEM_GLOBALIZATION_INVARIANT` * build index.js Signed-off-by: Alex Chi <iskyzh@gmail.com> * Version updates (machulav#92) * Update runner version * Update package-lock.json * Update dist * Add link for donation to help Ukraine protect itself from russian occupants * Update donation URL * Update wordings * Bump @actions/core from 1.6.0 to 1.9.1 (machulav#109) Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.6.0 to 1.9.1. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) --- updated-dependencies: - dependency-name: "@actions/core" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dist * Bump node-fetch from 2.6.6 to 2.6.7 (machulav#105) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.6 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.6...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dist * Fix deprecation warnings (machulav#123) * Update node version * Update version of packages * Update version of runner * Update version of actions * Update dist * Add required package to the documentation * Add 'pre-runner-script' option (machulav#154) Add a 'pre-runner-script' option to specify arbitrary bash commands to run before the runner starts up on the instance. This is useful if you need to install dependencies or have OS-specific setup steps. For example: - name: Start EC2 runner with: mode: start ec2-image-id: ami-07bdb09c49774f92e pre-runner-script: | sudo yum update -y && \ sudo yum install docker git libicu -y \ sudo systemctl enable docker Signed-off-by: Tony Hutter <hutter2@llnl.gov> * Compile dist * Removing dist * Add back dist --------- Signed-off-by: Alex Chi <iskyzh@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az93-126.zwmoqlwq51iuvls2zdlc0jzybe.xx.internal.cloudapp.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Volodymyr Machula <machulav@gmail.com> Co-authored-by: Jukka Palomäki <jukka.palomaki@paf.com> Co-authored-by: GitHub Actions <runner@fv-az90-268.oknmvzgco44exlvyi5fejcivhg.gx.internal.cloudapp.net> Co-authored-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: GitHub Actions <runner@fv-az238-896.lrtv1j1tcsgurjp4mtmc3vvjre.gx.internal.cloudapp.net> Co-authored-by: GitHub Actions <runner@fv-az335-98.st3fsr2bvbpu5iwsufzt3hrohh.gx.internal.cloudapp.net> Co-authored-by: GitHub Actions <runner@fv-az502-646.yzlryxntam3u3auahceqrxiktg.dx.internal.cloudapp.net> Co-authored-by: Tony Hutter <hutter2@llnl.gov>
mmoriani
pushed a commit
to ottimis/ec2-github-runner
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the octokit paginate to properly paginate the list call. This fixes #46.