Skip to content
This repository has been archived by the owner on Dec 9, 2022. It is now read-only.

Forward all issues for Kubeflow org; setup dev environment #60

Merged
merged 1 commit into from
Jan 18, 2020

Conversation

jlewi
Copy link
Collaborator

@jlewi jlewi commented Jan 17, 2020

  • Setup new staging and prod environments #57 is tracking setting up new staging and prod environments

    • This PR sets up a new staging (or dev environment)
    • We create a kustomize manifest for deploying the front end into that
      namespace
    • The staging environment is configured to use the dev instance of the
      issue label bot backend microservice (i.e the pubsub workers)
    • I created some python scripts to make it easier to setup the secrets.
    • The motivation for doing this was to test the changes to the front end
  • Front end now forwards all issues for the kubeflow org to the backend

kubeflow/code-intelligence#104 is an a test issue showing that the bot is
working.

  • Fix how keys are handled

    • For GOOGLE_APPLICATION_CREDENTIALS; depend on that environment variable
      being set and pointing to the file containing the private key;
      don't get the private key from an environment variable and then write it
      to a file.
  • For the GitHub App private key; use an environment variable to point to
    the file containing the PEM key.

  • Create a script to create the secrets.

  • Flask app is running in dev namespace

    • create_secrets.py creates secrets needed for dev instance

* machine-learning-apps#57 is tracking setting up new staging and prod environments

  * This PR sets up a new staging (or dev environment)
  * We create a kustomize manifest for deploying the front end into that
    namespace
  * The staging environment is configured to use the dev instance of the
    issue label bot backend microservice (i.e the pubsub workers)
  * I created some python scripts to make it easier to setup the secrets.
  * The motivation for doing this was to test the changes to the front end

* Front end now forwards all issues for the kubeflow org to the backend

  * This is needed because we want to use multiple models for all Kubeflow
    repos kubeflow/code-intelligence#70

  * The backend should also be configured with logging to measure the impact
    of the predictions.

kubeflow/code-intelligence#104 is an a test issue showing that the bot is
working.

* Fix how keys are handled

  * For GOOGLE_APPLICATION_CREDENTIALS; depend on that environment variable
    being set and pointing to the file containing the private key;
    don't get the private key from an environment variable and then write it
    to a file.

* For the GitHub App private key; use an environment variable to point to
  the file containing the PEM key.

* Create a script to create the secrets.

* Flask app is running in dev namespace

  * create_secrets.py creates secrets needed for dev instance
@jlewi
Copy link
Collaborator Author

jlewi commented Jan 17, 2020

@hamelsmu PTAL

@hamelsmu
Copy link
Contributor

/lgtm
/approve

@jlewi jlewi merged commit 15a9b82 into machine-learning-apps:master Jan 18, 2020
@sankiebot
Copy link

sankiebot bot commented Jan 29, 2020

Sankie Suggestion Friendly Ping: This PR is 12 days old. Please take action as appropriate

This comment is generated by our experimental reminder service.
We appreciate any ideas or feedback on how to make this feature more useful.
Please mark this comment as "resolved" [if you find it useful] / "won't fix" [if not].

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants