Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added package.json #94

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Added package.json #94

merged 1 commit into from
Jun 1, 2017

Conversation

jcesarmobile
Copy link
Collaborator

Used phonegap-plugin-speech-recognition as the name on the package.json, also changed the id to be the same (all the cordova ones were already picked, but feel free to change it if you don't like it)

Bumped minor version

Changed plugin.xml license to MIT as it's the license file used.

Closes #93 & #91

@ghost
Copy link

ghost commented Jun 1, 2017

@jcesarmobile when you will merge this fix? Thx.

@jcesarmobile
Copy link
Collaborator Author

@mosca90 I'm waiting for a review from @macdonst

@jcesarmobile jcesarmobile requested a review from macdonst June 1, 2017 15:42
@macdonst macdonst merged commit aa8b86d into macdonst:master Jun 1, 2017
@jcesarmobile jcesarmobile deleted the add-package branch June 1, 2017 15:55
@jcesarmobile
Copy link
Collaborator Author

I thought commenting "Closes #93 & #91" would close the issues once the PR is merged, but doesn't work

@macdonst
Copy link
Owner

macdonst commented Jun 1, 2017

Nope you have to do it manually. I'm going to publish to npm sometime today if the wifi is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants