Fix layout of the "Defer" date picker view #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e image. Also support optional parameters to return an image of certain size.
…e for the image. Also support optional parameters to return an image of certain size." This reverts commit 7a7f860.
Remove all unnecessary frame width declarations. added padding 4 to close button to visually seperate it from the view edges added vstack for date pickers with padding addeed to match the look and feel to be as close as possible to the previous version removed button hstack as it wasn't needed (stack of one item)
|
tested on macOS 11 and 12 |
|
I had planned on fixing this but yay, now I don't have to. Thanks buddy! :) |
|
ha - well was in the mood for it (and I might have ddid it in the last PR if I wasn't running a headache and realised where the change was needed)....anyway- pity that http image branch won't go away for whatever reason - revert, rebase, unmerge, exorcise, pull.....this is why people nuke and re-clone. :/ |
|
That's why I squashed this PR into a single commit. What I would suggest is destroying your development branch and then creating a new branch from my origin development branch. Should fix you up moving forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of fixing the issues raised in #246
A little more work but brings the view declaration into line with how other views are defined with stronger reliance on letting SwiftUI do the layout for the most part
Before:
After:
