fix #1374 #1380
Merged
fix #1374 #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output buffer size was sized using the function `LZ4F_compressFrameBound(, NULL)`, with the mention "cover worst scenario". That's incorrect : using `, NULL` covers the _default_ scenario, and there are ways to make the situation worse by using advanced command line options, starting with `-B4`. In some limit scenarios, it leads to situations where the output buffer is not large enough. Switched to determining the main ingredients of LZ4F_preferences_t during initialization and using actual compression parameters to determine the output buffer size thus avoiding corner cases where it's under-sized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal output buffer size is sized using the function
LZ4F_compressFrameBound(), with parameterNULL.A mention specifies "cover worst scenario", but that was incorrect : using
NULLcovers the default scenario, and there are ways to make the situation worse by using advanced command line options, like-B4. In some limit scenarios, it leads to situations where the output buffer is not deemed large enough to guarantee a successful compression.Switched to determining the main ingredients of
LZ4F_preferences_tduring initialization and using actual compression parameters to determine the output buffer size, thus avoiding corner cases like #1374 where it's under-sized.Added test from #1379 , where it was failing without this patch.
fix #1374