Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Makefile version number parsing more robust #1290

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Make Makefile version number parsing more robust #1290

merged 1 commit into from
Oct 13, 2023

Conversation

LocalSpook
Copy link
Contributor

As discussed in PR #1287.

@Cyan4973
Copy link
Member

minor comment:
it seems we are using this version extraction routine in many places,
to the point that I wonder if it would be better to have a single centralized version somewhere
that would be accessible by all these build systems.

This could be a future follow up.

@Cyan4973 Cyan4973 merged commit e2bea9e into lz4:dev Oct 13, 2023
@moonfruit moonfruit mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LocalSpook @Cyan4973