Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure on PowerPc architecture #192

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

giuliobenetti
Copy link
Contributor

In PowerPc Linux only get_ra() exists0 and conflicts with local get_ra() that has a completely different purpose. So let's rename local get_ra() to wifi_get_ra() to make it different from Linux's get_ra().

Signed-off-by: Giulio Benetti giulio.benetti@benettiengineering.com

In PowerPc Linux only get_ra() exists[0] and conflicts with local get_ra()
that has a completely different purpose. So let's rename local get_ra()
to wifi_get_ra() to make it different from Linux's get_ra().

[0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/include/asm/disassemble.h#n49

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
arnout pushed a commit to buildroot/buildroot that referenced this pull request Oct 24, 2022
Add local patch(pending upstream[0]) to fix build failure with PowerPC due
to a package re-defition of get_ra() that is only defined in Linux PowerPC
implementation.

[0]: lwfinger/rtl8723bu#192

Fixes:
http://autobuild.buildroot.net/results/99571b055e6185d57f89b90821b76099ebc766ed/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
arnout pushed a commit to buildroot/buildroot that referenced this pull request Nov 4, 2022
Add local patch(pending upstream[0]) to fix build failure with PowerPC due
to a package re-defition of get_ra() that is only defined in Linux PowerPC
implementation.

[0]: lwfinger/rtl8723bu#192

Fixes:
http://autobuild.buildroot.net/results/99571b055e6185d57f89b90821b76099ebc766ed/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
(cherry picked from commit 9833f11)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
arnout pushed a commit to buildroot/buildroot that referenced this pull request Nov 4, 2022
Add local patch(pending upstream[0]) to fix build failure with PowerPC due
to a package re-defition of get_ra() that is only defined in Linux PowerPC
implementation.

[0]: lwfinger/rtl8723bu#192

Fixes:
http://autobuild.buildroot.net/results/99571b055e6185d57f89b90821b76099ebc766ed/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
(cherry picked from commit 9833f11)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
@giuliobenetti
Copy link
Contributor Author

Hi @lwfinger,

thank you for the super fast merge of #194.
Can you please merge this PR too? This way I can drop local patch in Buildroot.
As you can see it's referenced a lot and it's been build-tested a lot with Buildroot autobuilders.
Thanks in advance!

@lwfinger lwfinger merged commit f1dbe1c into lwfinger:master Dec 28, 2022
@lwfinger
Copy link
Owner

Sorry that this one took a long time. Thanks.

@giuliobenetti
Copy link
Contributor Author

giuliobenetti commented Dec 28, 2022

@lwfinger thanks a lot. And I have to say sorry instead to @dini because he already opened a PR for Linux 6.1 #193 :-/ and I didn't check before creating patches...

@giuliobenetti giuliobenetti deleted the fix/powerpc-build branch December 28, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants