fix(docs): fix broken links in ./lvgl/README.md #7146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kissa96
approved these changes
Oct 25, 2024
|
Can we fix it with Sphinx redirect so that the old links will work too? |
I'm on it. |
|
Hi, Gábor! ( @kisvegabor ) I am ready with the links that were in I added just that subset of changes into the And it is making me wonder if I need to make a file-rename map, since my need to remember where things went has come up many times now.... |
|
Hi, Gábor! ( @kisvegabor ) Because thinking through where documents moved has now come across my plate so many times (including the modifications to Kind regards, |
|
Also, now that I have this in list form, in theory, all of the MOVED files could be put into the This seems a bit far, but it is doable, and would not take long. And it would ELIMINATE 404 errors no matter where in the field they were stored. Let me know. Kind regards, P.S. This is what it would look like: |
|
Wow, there are a lot links to fix. Can we make use of wildcards? |
I believe I saw some facilities for wildcards. However, given I have the list and a generated test, we don't need wildcards. It would just make it more complicated. You can see it on my demo website. I did a copy/paste of the above into http://crystal-clear-research.com/for_gabor/demo/docs.lvgl.io/master/layouts/flex.html Kind regards, |
kisvegabor
previously approved these changes
Oct 25, 2024
Perfect!! |
|
@kisvegabor P.S. Don't forget PR #7144. Reason: it adds a lot of documentation quality to styles, flex, and grid! They read so much better! |
|
@kisvegabor P.P.S. Sorry to invalidate your approval above, but I had not yet added in the rest of the redirects -- which WAS already showing and present in the "demo web site". The redirects that were previously present are unchanged, just more was added (what you tested on-line in the links above). |
...fix a few broken links in translated README files. (Full URLs in the README's have to be spelled out because they do not get translated by Sphinx. So :ref: links won't work. Also, 2 paths changed after the translated README's had changed: - modules => main-components - add-lvgl-to-your-project/project =>add-lvgl-to-your-project/connecting_lvgl
vwheeler63
force-pushed
the
fix/fix_readme_links
branch
from
517f95b to
422d950
Compare
FASTSHIFT
approved these changes
Oct 28, 2024
By the way, the new redirects dictionary in Thank you, @FASTSHIFT ! You merged this as I was typing this message! Kind regards, |
rodb70
pushed a commit
to rodb70/lvgl
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes links in ./lvgl/README.md that were broken from PR #7136.
cc: @kisvegabor
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig. n/ascripts/code-format.py(astyle v3.4.12needs to installed by runningcd scripts; ./install_astyle.sh) and follow the Code Conventions. n/a