feat(vg_lite): add ARGB1555 ARGB4444 ARGB2222 support #7028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisvegabor
reviewed
Oct 10, 2024
tests/ref_imgs_vg_lite/draw/render/argb1555/demo_render_arc_image_opa_128.png
Outdated
Show resolved
Hide resolved
tests/ref_imgs_vg_lite/draw/render/argb2222/demo_render_blend_mode_opa_128.png
Outdated
Show resolved
Hide resolved
kisvegabor
reviewed
Oct 14, 2024
tests/ref_imgs_vg_lite/draw/render/argb1555/demo_render_arc_normal_opa_255.png
Outdated
Show resolved
Hide resolved
|
@kisvegabor This PR just adds new color formats, some drawing errors may be problems with ThorVG render, can we fix them later? |
FASTSHIFT
previously approved these changes
Oct 17, 2024
kisvegabor
reviewed
Oct 17, 2024
tests/ref_imgs_vg_lite/draw/render/argb1555/demo_render_arc_normal_opa_255.png
Outdated
Show resolved
Hide resolved
kisvegabor
reviewed
Oct 17, 2024
tests/ref_imgs_vg_lite/draw/render/argb1555/demo_render_arc_image_opa_128.png
Outdated
Show resolved
Hide resolved
Signed-off-by: yushuailong1 <yushuailong1@xiaomi.com>
Signed-off-by: yushuailong1 <yushuailong1@xiaomi.com>
FASTSHIFT
approved these changes
Oct 19, 2024
XuNeo
approved these changes
Oct 22, 2024
Yes, we can add relevant tests later. |
rodb70
pushed a commit
to rodb70/lvgl
that referenced
this pull request
Nov 8, 2024
Signed-off-by: yushuailong1 <yushuailong1@xiaomi.com> Co-authored-by: yushuailong1 <yushuailong1@xiaomi.com> Co-authored-by: pengyiqiang <pengyiqiang@xiaomi.com> Co-authored-by: FASTSHIFT <vifextech@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for ARGB1555 ARGB4444 ARGB2222. vg_lite supports this format. In some cases, these color formats can reduce memory usage.
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle v3.4.12needs to installed by runningcd scripts; ./install_astyle.sh) and follow the Code Conventions.